linux-kernel - Re: [PATCH v3 3/3] spi: acpi: Initialize modalias from of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VeLy-oTUjgQNATt+gXhCVh-ATDswetLZpE3_7Z-wrF0qw@mail.gmail.com>
Date:   Fri, 27 Jan 2017 15:43:27 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     "Dan O'Donovan" <dan@...tex.com>
Cc:     "linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
        "Rafael J . Wysocki" <rjw@...ysocki.net>,
        Jarkko Nikula <jarkko.nikula@...el.com>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Mark Brown <broonie@...nel.org>, Len Brown <lenb@...nel.org>,
        linux-i2c@...r.kernel.org, Wolfram Sang <wsa@...-dreams.de>,
        linux-spi <linux-spi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Crestez Dan Leonard <leonard.crestez@...el.com>
Subject: Re: [PATCH v3 3/3] spi: acpi: Initialize modalias from of_compatible

On Fri, Jan 27, 2017 at 12:35 PM, Dan O'Donovan <dan@...tex.com> wrote:
> On 01/23/2017 05:11 PM, Andy Shevchenko wrote:
>> On Mon, Jan 23, 2017 at 6:08 PM, Dan O'Donovan <dan@...tex.com> wrote:

>>> +               strlcpy(spi->modalias, acpi_device_hid(adev),
>>> +                       sizeof(spi->modalias));
>> Could this be one line?
> I couldn't see a way to reduce this to one line without exceeding 80
> chars or adding another line somewhere else, so I'll leave this one as
> it is if that's ok.

80 characters per line is not carved in stone. How many do you have
over? 3 like "s);"?

-- 
With Best Regards,
Andy Shevchenko