linux-kernel - Re: [PATCH] greybus: Fix coding stye error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170127143710.GB14447@LF005>
Date:   Fri, 27 Jan 2017 15:37:12 +0100
From:   Maxime Rossi Bellom <mrossibellom@...il.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     Johan Hovold <johan@...nel.org>, devel@...verdev.osuosl.org,
        greybus-dev@...ts.linaro.org, gregkh@...uxfoundation.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] greybus: Fix coding stye error

On Fri, Jan 27, 2017 at 05:13:01PM +0300, Dan Carpenter wrote:
> I guess I'm not a fan of really long prefixes...  I've complained before
> to other people so don't feel special.  Prefixes are something that
> people add without thinking as if they always make the code better and
> I do blame JAVA influence for this...
> 
> The "_interface" really doesn't add anything because that's always the
> first parameter that we pass.  It's just filler.
> 
> I think "try" is better than "request" probably.  Request is regularly
> used as a noun and try never is.
> 
> But I don't care at this point.
> 
> regards,
> dan carpenter
>

I don't feel confortable removing a word in the function name as I don't 
fully understand the code.

What about shorting interface into intf as it is used in connection->intf ?

Johan, what do you mean by using connection->intf in this case ? Are you
talking about a global variable usable in this context ?

Thanks,
Maxime