linux-kernel - Re: [PATCH v1 3/3] MAINTAINERS: xen, kvm: track pvclock-abi.h changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8880778c-109a-e799-4361-442bcfd72467@suse.com>
Date:   Fri, 27 Jan 2017 15:54:01 +0100
From:   Juergen Gross <jgross@...e.com>
To:     Joao Martins <joao.m.martins@...cle.com>,
        linux-kernel@...r.kernel.org, xen-devel@...ts.xenproject.org,
        kvm@...r.kernel.org
Cc:     Boris Ostrovsky <boris.ostrovsky@...cle.com>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Radim Krcmar <rkrcmar@...hat.com>,
        Andy Lutomirski <luto@...capital.net>
Subject: Re: [PATCH v1 3/3] MAINTAINERS: xen, kvm: track pvclock-abi.h changes

On 25/01/17 18:33, Joao Martins wrote:
> This file defines an ABI shared between guest and hypervisor(s)
> (KVM, Xen) and as such there should be an correspondent entry in
> MAINTAINERS file. Notice that there's already a text notice at the
> top of the header file, hence this commit simply enforces it more
> explicitly and have both peers noticed when such changes happen.
> 
> Signed-off-by: Joao Martins <joao.m.martins@...cle.com>
> ---
> This was suggested by folks at xen-devel as we missed some of the
> ABI additions (e.g. flags field in pvti, TSC stable bit) - so this
> patch is to help preventing that from happening. Alternatively I
> could instead add a "PVCLOCK ABI" section in this file with the
> two mailing lists.

I don't mind either way. In case of an own section: make it more generic
like "PARAVIRT ABIS" as there might be more than PVCLOCK (if not now
maybe in future).

For both variants:

Acked-by: Juergen Gross <jgross@...e.com>


Juergen

> ---
>  MAINTAINERS | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 26edd83..c4315d1 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -7041,6 +7041,7 @@ F:	Documentation/virtual/kvm/
>  F:	arch/*/kvm/
>  F:	arch/x86/kernel/kvm.c
>  F:	arch/x86/kernel/kvmclock.c
> +F:	arch/x86/include/asm/pvclock-abi.h
>  F:	arch/*/include/asm/kvm*
>  F:	include/linux/kvm*
>  F:	include/uapi/linux/kvm*
> @@ -13483,6 +13484,7 @@ M:	Juergen Gross <jgross@...e.com>
>  L:	xen-devel@...ts.xenproject.org (moderated for non-subscribers)
>  T:	git git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git
>  S:	Supported
> +F:	arch/x86/include/asm/pvclock-abi.h
>  F:	arch/x86/xen/
>  F:	drivers/*/xen-*front.c
>  F:	drivers/xen/
>