linux-kernel - Re: [PATCH 2/2] m68k: replaced gcc specific macros with ones from compiler.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAP=VYLobUppjdMpeoQ7gXn60zmbEZU6d5Ga1mccCPbbpw9n1yA@mail.gmail.com>
Date:   Fri, 27 Jan 2017 11:39:12 -0500
From:   Paul Gortmaker <paul.gortmaker@...driver.com>
To:     Gideon Israel Dsouza <gidisrael@...il.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        LKML <linux-kernel@...r.kernel.org>, gerg@...ux-m68k.org,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        linux-m68k@...ts.linux-m68k.org,
        "linux-next@...r.kernel.org" <linux-next@...r.kernel.org>
Subject: Re: [PATCH 2/2] m68k: replaced gcc specific macros with ones from compiler.h

On Tue, Jan 24, 2017 at 7:14 AM, Gideon Israel Dsouza
<gidisrael@...il.com> wrote:
> There is <linux/compiler.h> which provides macros for various gcc specific
> constructs. Eg: __weak for __attribute__((weak)). I've cleaned all
> instances of gcc specific attributes with the right macros for all files
> under /arch/m68k
>
> This patch depends on the previous with changes in

> @@ -17,6 +18,6 @@ void nf_init(void);
>  void nf_shutdown(void);
>
>  void nfprint(const char *fmt, ...)
> -       __attribute__ ((format (printf, 1, 2)));
> +       __print(1, 2);
>

You've gone from printf to print here.  This commit is breaking the
linux-next builds on m68k.  I see the kbuild bot tripped over the same
issue and did the same bisect.

http://kisskb.ellerman.id.au/kisskb/buildresult/12916834/

Paul.
--