linux-kernel - Re: [PATCH V2 0/4] efi/x86: move efi bgrt init code to early init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKv+Gu9C75q3J_8w68d+m=ZMcUh2MxU+c-1xvLwyY+mceSigbg@mail.gmail.com>
Date:   Fri, 27 Jan 2017 17:03:36 +0000
From:   Ard Biesheuvel <ard.biesheuvel@...aro.org>
To:     Dave Young <dyoung@...hat.com>
Cc:     Matt Fleming <matt@...eblueprint.co.uk>,
        "linux-efi@...r.kernel.org" <linux-efi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "x86@...nel.org" <x86@...nel.org>,
        Nicolai Stange <nicstange@...il.com>,
        Ingo Molnar <mingo@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        "hpa@...or.com" <hpa@...or.com>,
        Dan Williams <dan.j.williams@...el.com>,
        Mika Penttilä <mika.penttila@...tfour.com>,
        Bhupesh Sharma <bhsharma@...hat.com>
Subject: Re: [PATCH V2 0/4] efi/x86: move efi bgrt init code to early init

On 16 January 2017 at 02:45, Dave Young <dyoung@...hat.com> wrote:
> Hi,
>
> Here the the update of the series for moving bgrt init code to early init.
>
> Main changes is:
> - Move the 1st patch to the last because it does not block the 2nd patch
> any more with Peter's patch to prune invlid memmap entries:
> https://git.kernel.org/cgit/linux/kernel/git/efi/efi.git/commit/?h=next&id=b2a91
> a35445229
> But it is still tood to have since efi_mem_reserve only cares about boot related
> mem ranges.
>
> - Other comments about code itself, details please the the patches themselves.
>
>  arch/x86/include/asm/efi.h       |    1
>  arch/x86/kernel/acpi/boot.c      |   12 +++++++
>  arch/x86/platform/efi/efi-bgrt.c |   59 ++++++++++++++++-----------------------
>  arch/x86/platform/efi/efi.c      |   26 +++--------------
>  arch/x86/platform/efi/quirks.c   |    2 -
>  drivers/acpi/bgrt.c              |   28 +++++++++++++-----
>  drivers/firmware/efi/fake_mem.c  |    3 +
>  drivers/firmware/efi/memmap.c    |   22 +++++++++++++-
>  include/linux/efi-bgrt.h         |    7 +---
>  include/linux/efi.h              |    5 +--
>  init/main.c                      |    1
>  11 files changed, 92 insertions(+), 74 deletions(-)
>

Dave,

I have pushed these to efi/next: please double check if I did it
correctly. I had some trouble applying these given that I rebased
efi/next onto -rc4. However, the fact that you are not using standard
git cover letters and emails doesn't help things, so could you
*please* use standard git send-email to post to linux-efi in the
future? Thanks.

Ard.