linux-kernel - Re: [PATCH 1/2] compiler-gcc.h: Added new macro for gcc attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPNrq4yVFRuZXRof9sPu+QvJmHdfN4sOcbjdXHnkqq1WcvtycQ@mail.gmail.com>
Date:   Fri, 27 Jan 2017 22:50:52 +0530
From:   "Gideon D'souza" <gidisrael@...il.com>
To:     Joe Perches <joe@...ches.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Greg Ungerer <gerg@...ux-m68k.org>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        linux-m68k <linux-m68k@...ts.linux-m68k.org>
Subject: Re: [PATCH 1/2] compiler-gcc.h: Added new macro for gcc attribute

>Please don't top post and perhaps Andrew can fix it up instead.

What do you mean when you say "top post" I shouldn't re-send it?

On Fri, Jan 27, 2017 at 7:15 PM, Joe Perches <joe@...ches.com> wrote:
> On Fri, 2017-01-27 at 19:04 +0530, Gideon D'souza wrote:
>> Ok, I noticed this went into Andrew's tree and is now in linux-next,
>> should I resend it?
>
> Please don't top post and perhaps Andrew can fix it up instead.
>
> Andrew, you need to change:
>
> #define __mode          __attribute__((mode(x)))
>
> to
>
> #define __mode(x)       __attribute__((mode(x)))
>
> thanks.
>
>> On Wed, Jan 25, 2017 at 10:20 AM, Gideon D'souza <gidisrael@...il.com> wrote:
>> > > #define __mode(x)       __attribute__((mode(x)))
>> >
>> > Well that's embarrassing. I so sorry for the trouble guys :( I'll resend this.
>> >
>> > On Wed, Jan 25, 2017 at 7:20 AM, Joe Perches <joe@...ches.com> wrote:
>> > > On Tue, 2017-01-24 at 17:44 +0530, Gideon Israel Dsouza wrote:
>> > > > Added __mode(x) into compiler-gcc.h as part of a cleanup task I've
>> > > > taken up, to replace gcc specific attributes with macros.
>> > > >
>> > > > Last accepted patch I sent into linux-next for crypto: d8c34b949d8c:
>> > > > crypto: Replaced gcc specific attributes with macros from compiler.h
>> > > >
>> > > > The last commit of this task that went through you: 52f5684c8e1ec
>> > > > kernel: use macros from compiler.h instead of __attribute__((...))
>> > > >
>> > > > The next patch is for cleaning up the m68k subsystem and it requires
>> > > > a new macro to wrap __attribute__ ((mode (...)))
>> > >
>> > > []
>> > > > diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h
>> > >
>> > > []
>> > > > @@ -121,6 +121,7 @@
>> > > >  #define __attribute_const__  __attribute__((__const__))
>> > > >  #define __maybe_unused               __attribute__((unused))
>> > > >  #define __always_unused              __attribute__((unused))
>> > > > +#define __mode                  __attribute__((mode(x)))
>> > >
>> > > Huh?
>> > >
>> > > Perhaps you meant
>> > >
>> > > #define __mode(x)       __attribute__((mode(x)))
>> > >
>> > > ?
>> > >