linux-kernel - Re: [PATCH 4/4] Input: leds - force the LED status after .probe()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170127181925.GI13244@mail.corp.redhat.com>
Date:   Fri, 27 Jan 2017 19:19:25 +0100
From:   Benjamin Tissoires <benjamin.tissoires@...hat.com>
To:     Samuel Thibault <samuel.thibault@...-lyon.org>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jslaby@...e.com>, linux-input@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/4] Input: leds - force the LED status after .probe()

On Jan 27 2017 or thereabouts, Samuel Thibault wrote:
> Benjamin Tissoires, on Fri 27 Jan 2017 18:13:18 +0100, wrote:
> > Once the host has set the initial setting of the LEDs after a new
> > USB keyboard gets connected, they appear to have a SET_IDLE command
> > sent which turns of the LEDs.
> > This means that the initial step of setting the LEDs on a keyboard is
> > just reset once .probe() finishes.
> > To be sure we set the LEDs, start a delayed task to try to resend
> > them after 1 sec.
> 
> If there is such issue, I'd say fix the issue (what is sending
> SET_IDLE?) instead of working around it.
> 

That is the question. I am not even sure who sends the SET_IDLE, and if
this is something that can be controlled without disturbing too many
devices. I'll dig further then.

Cheers,
Benjamin