linux-kernel - Re: [PATCH v4 3/3] p54: convert to sysdata API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFxCH=4k_88ELm8Dm_tBCNO3NEKOvRk3BSaLeCUdaNE=1A@mail.gmail.com>
Date:   Fri, 27 Jan 2017 12:53:38 -0800
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     "Luis R. Rodriguez" <mcgrof@...nel.org>
Cc:     Greg KH <gregkh@...uxfoundation.org>,
        Ming Lei <ming.lei@...onical.com>,
        Borislav Petkov <bp@...en8.de>, Daniel Wagner <wagi@...om.org>,
        Tom Gundersen <teg@...m.no>,
        Mauro Carvalho Chehab <mchehab@....samsung.com>,
        Rafał Miłecki <zajec5@...il.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Vikram Mulukutla <markivx@...eaurora.org>,
        Stephen Boyd <stephen.boyd@...aro.org>,
        Mark Brown <broonie@...nel.org>,
        Mimi Zohar <zohar@...ux.vnet.ibm.com>,
        Takashi Iwai <tiwai@...e.de>,
        Johannes Berg <johannes@...solutions.net>,
        Christian Lamparter <chunkeey@...glemail.com>,
        Hauke Mehrtens <hauke@...ke-m.de>,
        Josh Boyer <jwboyer@...oraproject.org>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        David Woodhouse <dwmw2@...radead.org>,
        Jiri Slaby <jslaby@...e.com>,
        Andy Lutomirski <luto@...capital.net>,
        Wu Fengguang <fengguang.wu@...el.com>,
        Richard Purdie <rpurdie@...ys.net>,
        Jacek Anaszewski <j.anaszewski@...sung.com>,
        Abhay_Salunke@...l.com, Julia Lawall <Julia.Lawall@...6.fr>,
        Gilles.Muller@...6.fr, nicolas.palix@...g.fr,
        David Howells <dhowells@...hat.com>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        arend.vanspriel@...adcom.com, Kalle Valo <kvalo@...eaurora.org>
Subject: Re: [PATCH v4 3/3] p54: convert to sysdata API

On Fri, Jan 27, 2017 at 10:23 AM, Luis R. Rodriguez <mcgrof@...nel.org> wrote:
>> So I'm really not seeing why you want to make these conversions that
>> just make code worse.
>
> The real goal here was first to actually provide a flexible API to enable
> more advanced features to be added without having to affect existing
> callers, as has been done before.

So I've said this before, and I'll say this one more time:

It's fine if we make the internal implementation of some generic "load
data from the filesystem or user" be this kind of new flexible API
that is internally called "driver_data_request()" or whatever.

But dammit, that is NOT AN EXCUSE for then making crap patches that
just replace the existing firmware users.

If the new interface cannot be wrapped in the old names (and the old
semantics) the new interface is shit and should never ever go
anywhere.

So leave the existing users alone. Concentrate on _only_ the parts
where  there is actual and real need of new features. Don't try to
rename or extend current drivers. Don't send out these patches that
make drivers actively uglier. Really.

I really question the whole thing when there are things like this going on.

            Linus