linux-kernel - Re: [PATCH] staging: octeon-usb: Fix coding style issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170127072907.GA29616@kroah.com>
Date:   Fri, 27 Jan 2017 08:29:07 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     William Blough <devel@...ugh.us>
Cc:     Aaro Koskinen <aaro.koskinen@....fi>, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: octeon-usb: Fix coding style issues

On Thu, Jan 26, 2017 at 10:46:02PM -0500, William Blough wrote:
> Wrap lines that exceed 80 characters.
> 
> Signed-off-by: William Blough <devel@...ugh.us>
> ---
>  drivers/staging/octeon-usb/octeon-hcd.c | 18 ++++++++++++------
>  1 file changed, 12 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeon-hcd.c
> index 9a7858a..6b86bfb 100644
> --- a/drivers/staging/octeon-usb/octeon-hcd.c
> +++ b/drivers/staging/octeon-usb/octeon-hcd.c
> @@ -2635,13 +2635,19 @@ static int cvmx_usb_poll_channel(struct octeon_hcd *usb, int channel)
>  				/* Disable all interrupts except CHHLTD */
>  				hcintmsk.u32 = 0;
>  				hcintmsk.s.chhltdmsk = 1;
> -				cvmx_usb_write_csr32(usb,
> -						     CVMX_USBCX_HCINTMSKX(channel, usb->index),
> -						     hcintmsk.u32);
> +				cvmx_usb_write_csr32(
> +						usb,
> +						CVMX_USBCX_HCINTMSKX(
> +								channel,
> +								usb->index),
> +						hcintmsk.u32);
>  				usbc_hcchar.s.chdis = 1;
> -				cvmx_usb_write_csr32(usb,
> -						     CVMX_USBCX_HCCHARX(channel, usb->index),
> -						     usbc_hcchar.u32);
> +				cvmx_usb_write_csr32(
> +						usb,
> +						CVMX_USBCX_HCCHARX(
> +								channel,
> +								usb->index),
> +						usbc_hcchar.u32);
>  				return 0;
>  			} else if (usbc_hcint.s.xfercompl) {
>  				/*

That's horrid, the original code looks better, please leave it as-is.

thanks,

greg k-h