linux-kernel - Re: [PATCH] drm/ttm: Make sure BOs being swapped out are cacheable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170127073040.l2ofthrhsbteahpx@phenom.ffwll.local>
Date:   Fri, 27 Jan 2017 08:30:40 +0100
From:   Daniel Vetter <daniel@...ll.ch>
To:     Thomas Hellstrom <thellstrom@...are.com>
Cc:     Michel Dänzer <michel@...nzer.net>,
        Sinclair Yeh <syeh@...are.com>,
        Christian König <christian.koenig@....com>,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        Daniel Vetter <daniel.vetter@...ll.ch>
Subject: Re: [PATCH] drm/ttm: Make sure BOs being swapped out are cacheable

On Fri, Jan 27, 2017 at 07:23:58AM +0100, Thomas Hellstrom wrote:
> On 01/27/2017 03:29 AM, Michel Dänzer wrote:
> > On 26/01/17 09:46 AM, Sinclair Yeh wrote:
> >> On Wed, Jan 25, 2017 at 10:49:33AM +0100, Christian König wrote:
> >>> Am 25.01.2017 um 10:25 schrieb Thomas Hellstrom:
> >>>> On 01/25/2017 09:21 AM, Michel Dänzer wrote:
> >>>>> From: Michel Dänzer <michel.daenzer@....com>
> >>>>>
> >>>>> The current caching state may not be tt_cached, even though the
> >>>>> placement contains TTM_PL_FLAG_CACHED, because placement can contain
> >>>>> multiple caching flags. Trying to swap out such a BO would trip up the
> >>>>>
> >>>>> 	BUG_ON(ttm->caching_state != tt_cached);
> >>>>>
> >>>>> in ttm_tt_swapout.
> >>>>>
> >>>>> Cc: stable@...r.kernel.org
> >>>>> Signed-off-by: Michel Dänzer <michel.daenzer@....com>
> >>>> Reviewed-by: Thomas Hellstrom <thellstrom@...are.com>
> >>> Reviewed-by: Christian König <christian.koenig@....com>.
> >> Reviewed-by: Sinclair Yeh <syeh@...are.com>
> > Thanks for the reviews! Via which tree should we merge this?
> >
> >
> I don't maintain a TTM tree any longer. Let's check with Daniel if he
> can merge it through drm-misc.

I'm trying very hard not to get volunteered for ttm maintainer :-)
Nominally Alex&Christian have drm-misc commit rights, but they haven't
used them yet. But I think merging through drm-misc would make sense,
there's regular pull request trains for both -next and -fixes. Or merge
through the amd tree with Dave's ack, but I'd really like to get amd folks
into the drm-misc group ...
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch