linux-kernel - Re: [PATCH 22/50] x86/boot/e820: Convert printk(KERN_* ...) to pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1485644341.6833.3.camel@perches.com>
Date:   Sat, 28 Jan 2017 14:59:01 -0800
From:   Joe Perches <joe@...ches.com>
To:     Ingo Molnar <mingo@...nel.org>, linux-kernel@...r.kernel.org
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Andy Lutomirski <luto@...capital.net>,
        Borislav Petkov <bp@...en8.de>,
        "H . Peter Anvin" <hpa@...or.com>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Yinghai Lu <yinghai@...nel.org>
Subject: Re: [PATCH 22/50] x86/boot/e820: Convert printk(KERN_* ...) to
 pr_*()

On Sat, 2017-01-28 at 23:11 +0100, Ingo Molnar wrote:
> No change in functionality.

Not true.

> @@ -419,11 +419,11 @@ __e820_update_range(struct e820_table *table, u64 start, u64 size, unsigned old_
>  		size = ULLONG_MAX - start;
>  
>  	end = start + size;
> -	printk(KERN_DEBUG "e820: update [mem %#010Lx-%#010Lx] ", start, end - 1);
> +	pr_debug("e820: update [mem %#010Lx-%#010Lx] ", start, end - 1);

#define DEBUG is not set here so this conversion is
not equivalent.

pr_debug will be removed unless CONFIG_DYNAMIC_DEBUG
is enabled and also will not be enabled by default.

>  	e820_print_type(old_type);
> -	printk(KERN_CONT " ==> ");
> +	pr_cont(" ==> ");

This will always be emitted.

> @@ -495,10 +495,10 @@ u64 __init e820_remove_range(u64 start, u64 size, unsigned old_type, int checkty
>  		size = ULLONG_MAX - start;
>  
>  	end = start + size;
> -	printk(KERN_DEBUG "e820: remove [mem %#010Lx-%#010Lx] ", start, end - 1);
> +	pr_debug("e820: remove [mem %#010Lx-%#010Lx] ", start, 

etc...