linux-kernel - Re: [PATCH v11 1/2] serial: exar: split out the exar code from 8250

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 30 Jan 2017 05:47:41 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc:     kbuild-all@...org, Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jslaby@...e.com>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org
Subject: Re: [PATCH v11 1/2] serial: exar: split out the exar code from
 8250_pci

Hi Sudip,

[auto build test WARNING on tty/tty-testing]
[also build test WARNING on v4.10-rc5 next-20170125]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Sudip-Mukherjee/serial-exar-split-out-the-exar-code-from-8250_pci/20170130-045633
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing
config: x86_64-rhel (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings

All warnings (new ones prefixed by >>):

   drivers/tty/serial/8250/8250_exar.c: In function 'exar_pci_probe':
>> drivers/tty/serial/8250/8250_exar.c:207:49: warning: 'board' may be used uninitialized in this function [-Wmaybe-uninitialized]
     maxnr = pci_resource_len(pcidev, bar) >> (board->reg_shift + 3);
                                               ~~~~~^~~~~~~~~~~

vim +/board +207 drivers/tty/serial/8250/8250_exar.c

   191		port->port.private_data = NULL;
   192	}
   193	
   194	static int
   195	exar_pci_probe(struct pci_dev *pcidev, const struct pci_device_id *ent)
   196	{
   197		unsigned int nr_ports, i, bar = 0, maxnr;
   198		struct exar8250_board *board;
   199		struct uart_8250_port uart;
   200		struct exar8250 *priv;
   201		int rc;
   202	
   203		rc = pcim_enable_device(pcidev);
   204		if (rc)
   205			return rc;
   206	
 > 207		maxnr = pci_resource_len(pcidev, bar) >> (board->reg_shift + 3);
   208	
   209		nr_ports = board->num_ports ? board->num_ports : pcidev->device & 0x0f;
   210	
   211		priv = devm_kzalloc(&pcidev->dev, sizeof(*priv) +
   212				    sizeof(unsigned int) * nr_ports,
   213				    GFP_KERNEL);
   214		if (!priv)
   215			return -ENOMEM;

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (38290 bytes)