linux-kernel - Re: [PATCH 1/2] iio: distance: add dt binding for devantech-srf04

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1701291015510.20492@pmeerw.net>
Date:   Sun, 29 Jan 2017 10:19:31 +0100 (CET)
From:   Peter Meerwald-Stadler <pmeerw@...erw.net>
To:     Andreas Klinger <ak@...klinger.de>
cc:     jic23@...nel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-iio@...r.kernel.org
Subject: Re: [PATCH 1/2] iio: distance: add dt binding for devantech-srf04

On Sun, 29 Jan 2017, Andreas Klinger wrote:

> This patch adds dt binding for devantech ultrasonic ranger srf04.

comments below
 
> The vendor "devantech" was already added to the vendor list with 
> 	"[PATCH v4 1/3] iio: distance: srf08: add trivial DT binding"
> 
> Signed-off-by: Andreas Klinger <ak@...klinger.de>
> ---
>  .../bindings/iio/proximity/devantech-srf04.txt          | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/proximity/devantech-srf04.txt
> 
> diff --git a/Documentation/devicetree/bindings/iio/proximity/devantech-srf04.txt b/Documentation/devicetree/bindings/iio/proximity/devantech-srf04.txt
> new file mode 100644
> index 000000000000..4ea29ef3ff89
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/proximity/devantech-srf04.txt
> @@ -0,0 +1,17 @@
> +* Devantech SRF04 ultrasonic range finder
> +  Bit-banging driver
> +
> +Required properties:
> + - compatible:	Should be "devantech,srf04"
> + - trig-gpios:	Definition of the GPIO for the triggering input
> + - echo-gpios:	Definition of the GPIO for the echo

"for the echo"
maybe some more explanation? it sounds somewhat incomplete to me

in the driver you have "failed to get echo-gpiod", maybe it should be gpios there?

> +		needs to be an interrupt input
> +		See Documentation/devicetree/bindings/gpio/gpio.txt
> +
> +Example:
> +srf04@0 {
> +	compatible = "devantech,srf04";
> +	trig-gpios = <&gpio1 15 GPIO_ACTIVE_HIGH>;
> +	echo-gpios = <&gpio2  6 GPIO_ACTIVE_HIGH>;
> +};
> +
> 

-- 

Peter Meerwald-Stadler
+43-664-2444418 (mobile)