linux-kernel - Re: [PATCH] Pinctrl: mvebu - Fix possible NULL derefrence.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170130092400.589f6a93@free-electrons.com>
Date:   Mon, 30 Jan 2017 09:24:00 +0100
From:   Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>
To:     Shailendra Verma <shailendra.v@...sung.com>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Laxman Dewangan <ldewangan@...dia.com>,
        Andreas Klinger <ak@...klinger.de>,
        Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
        Andrew Lunn <andrew@...n.ch>, Jamie Lentin <jm@...tin.co.uk>,
        Rob Herring <robh@...nel.org>, linux-gpio@...r.kernel.org,
        linux-kernel@...r.kernel.org, p.shailesh@...sung.com,
        ashish.kalra@...sung.com,
        Shailendra Verma <shailendra.capricorn@...il.com>
Subject: Re: [PATCH] Pinctrl: mvebu - Fix possible NULL derefrence.

Hello,

On Mon, 30 Jan 2017 10:21:43 +0530, Shailendra Verma wrote:
> of_match_device could return NULL, and so can cause a NULL
> pointer dereference later.
> 
> Signed-off-by: Shailendra Verma <shailendra.v@...sung.com>

In practice, I don't see how of_match_device() can return NULL here.
Indeed, those drivers only support Device Tree based probing, so
of_match_device() will always return a non-NULL value.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com