linux-kernel - Re: [PATCHv1 2/2] mmc: sdhci-msm: Remove unnecessary comments of CDC init sequence

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 30 Jan 2017 11:04:34 +0200
From:   Adrian Hunter <adrian.hunter@...el.com>
To:     Ritesh Harjani <riteshh@...eaurora.org>, ulf.hansson@...aro.org
Cc:     linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org,
        shawn.lin@...k-chips.com, linux-arm-msm@...r.kernel.org,
        georgi.djakov@...aro.org, asutoshd@...eaurora.org,
        stummala@...eaurora.org, venkatg@...eaurora.org,
        pramod.gurav@...aro.org, jeremymc@...hat.com, git@...r.de
Subject: Re: [PATCHv1 2/2] mmc: sdhci-msm: Remove unnecessary comments of CDC
 init sequence

On 24/01/17 10:50, Ritesh Harjani wrote:
> This removes CDC init sequence comments which are
> not useful anyway.
> 
> Signed-off-by: Ritesh Harjani <riteshh@...eaurora.org>

Acked-by: Adrian Hunter <adrian.hunter@...el.com>

> ---
>  drivers/mmc/host/sdhci-msm.c | 14 +-------------
>  1 file changed, 1 insertion(+), 13 deletions(-)
> 
> diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c
> index b3e8f44..10cdc84 100644
> --- a/drivers/mmc/host/sdhci-msm.c
> +++ b/drivers/mmc/host/sdhci-msm.c
> @@ -664,19 +664,7 @@ static int sdhci_msm_cdclp533_calibration(struct sdhci_host *host)
>  	config &= ~CORE_START_CDC_TRAFFIC;
>  	writel_relaxed(config, host->ioaddr + CORE_DDR_200_CFG);
>  
> -	/*
> -	 * Perform CDC Register Initialization Sequence
> -	 *
> -	 * CORE_CSR_CDC_CTLR_CFG0	0x11800EC
> -	 * CORE_CSR_CDC_CTLR_CFG1	0x3011111
> -	 * CORE_CSR_CDC_CAL_TIMER_CFG0	0x1201000
> -	 * CORE_CSR_CDC_CAL_TIMER_CFG1	0x4
> -	 * CORE_CSR_CDC_REFCOUNT_CFG	0xCB732020
> -	 * CORE_CSR_CDC_COARSE_CAL_CFG	0xB19
> -	 * CORE_CSR_CDC_DELAY_CFG	0x3AC
> -	 * CORE_CDC_OFFSET_CFG		0x0
> -	 * CORE_CDC_SLAVE_DDA_CFG	0x16334
> -	 */
> +	/* Perform CDC Register Initialization Sequence */
>  
>  	writel_relaxed(0x11800EC, host->ioaddr + CORE_CSR_CDC_CTLR_CFG0);
>  	writel_relaxed(0x3011111, host->ioaddr + CORE_CSR_CDC_CTLR_CFG1);
>