linux-kernel - Re: [PATCH V2] ARM: dts: BCM5301X: Add missing Netgear R8000 LEDs and Keys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <A0233283-B547-42E5-BBBF-3B75E592D858@gmail.com>
Date:   Mon, 30 Jan 2017 14:38:33 +0530
From:   Aditya Xavier <adityaxavier@...il.com>
To:     Rafał Miłecki <zajec5@...il.com>
Cc:     Hauke Mehrtens <hauke@...ke-m.de>,
        bcm-kernel-feedback-list <bcm-kernel-feedback-list@...adcom.com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Russell King <linux@...linux.org.uk>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Florian Fainelli <f.fainelli@...il.com>
Subject: Re: [PATCH V2] ARM: dts: BCM5301X: Add missing Netgear R8000 LEDs and
 Keys

Would you require me to send the revised Patch ?

Or would this do ?

And thanks for guiding me through this process :)


> On 29-Jan-2017, at 2:45 AM, Rafał Miłecki <zajec5@...il.com> wrote:
> 
> On 28 January 2017 at 15:37, AdityaXavier <adityaxavier@...il.com> wrote:
>> From: Aditya Xavier <adityaxavier@...il.com>
>> 
>> Added two WAN status LEDs and a GPIO Key for Brightness which were missing.
>> V2: Updated subject, Power LED names, and WAN labels.
> 
> Changelog (V2 ... part) should go into that /comments/ section (see below).
> Florian: can you drop that line when applying this patch? Otherwise it
> looks OK to me.
> 
> 
>> Signed-off-by: Aditya Xavier <adityaxavier@...il.com>
> 
> Acked-by: Rafał Miłecki <rafal@...ecki.pl>
> 
> Thanks for the patch!
> 
> 
>> ---
> 
> Right here, below these 3 dashes is a place where you can add extra
> comments (they won't go into log when doing "git am").
> 
>> arch/arm/boot/dts/bcm4709-netgear-r8000.dts | 22 ++++++++++++++++++++--
>> 1 file changed, 20 insertions(+), 2 deletions(-)
>> 
>> diff --git a/arch/arm/boot/dts/bcm4709-netgear-r8000.dts b/arch/arm/boot/dts/bcm4709-netgear-r8000.dts
>> index 92f8a72..90d4420 100644
>> --- a/arch/arm/boot/dts/bcm4709-netgear-r8000.dts
>> +++ b/arch/arm/boot/dts/bcm4709-netgear-r8000.dts
>> @@ -27,18 +27,30 @@
>>        leds {
>>                compatible = "gpio-leds";
>> 
>> -               power0 {
>> +               power-white {
>>                        label = "bcm53xx:white:power";
>>                        gpios = <&chipcommon 2 GPIO_ACTIVE_LOW>;
>>                        linux,default-trigger = "default-on";
>>                };
>> 
>> -               power1 {
>> +               power-amber {
>>                        label = "bcm53xx:amber:power";
>>                        gpios = <&chipcommon 3 GPIO_ACTIVE_LOW>;
>>                        linux,default-trigger = "default-off";
>>                };
>> 
>> +               wan-white {
>> +                       label = "bcm53xx:white:wan";
>> +                       gpios = <&chipcommon 8 GPIO_ACTIVE_LOW>;
>> +                       linux,default-trigger = "default-on";
>> +               };
>> +
>> +               wan-amber {
>> +                       label = "bcm53xx:amber:wan";
>> +                       gpios = <&chipcommon 9 GPIO_ACTIVE_HIGH>;
>> +                       linux,default-trigger = "default-off";
>> +               };
>> +
>>                5ghz-1 {
>>                        label = "bcm53xx:white:5ghz-1";
>>                        gpios = <&chipcommon 12 GPIO_ACTIVE_LOW>;
>> @@ -104,6 +116,12 @@
>>                        linux,code = <KEY_RESTART>;
>>                        gpios = <&chipcommon 6 GPIO_ACTIVE_LOW>;
>>                };
>> +
>> +               brightness {
>> +                       label = "Backlight";
>> +                       linux,code = <KEY_BRIGHTNESS_ZERO>;
>> +                       gpios = <&chipcommon 19 GPIO_ACTIVE_LOW>;
>> +               };
>>        };
>> };
>> 
>> --
>> 2.9.3
>> 
> 
> 
> 
> -- 
> Rafał