linux-kernel - Re: [PATCH] acpi: nfit: use %u format string specifier for unsigned ints

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <588F2A7F.8020501@bfs.de>
Date:   Mon, 30 Jan 2017 12:58:55 +0100
From:   walter harms <wharms@....de>
To:     Colin King <colin.king@...onical.com>
CC:     "Rafael J . Wysocki" <rjw@...ysocki.net>,
        Len Brown <lenb@...nel.org>,
        Dan Williams <dan.j.williams@...el.com>,
        Vishal Verma <vishal.l.verma@...el.com>,
        joeyli.kernel@...il.com, Toshi Kani <toshi.kani@....com>,
        linux-acpi@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] acpi: nfit: use %u format string specifier for unsigned
 ints



Am 30.01.2017 12:25, schrieb Colin King:
> From: Colin Ian King <colin.king@...onical.com>
> 
> scrub_mode and scrub_count are both unsigned ints, however, the %d
> format string specifier is being used instead of %u. Trivial fix,
> use %u.
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  drivers/acpi/nfit/core.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c
> index 2f82b8e..093b768 100644
> --- a/drivers/acpi/nfit/core.c
> +++ b/drivers/acpi/nfit/core.c
> @@ -906,7 +906,7 @@ static ssize_t hw_error_scrub_show(struct device *dev,
>  	struct nvdimm_bus_descriptor *nd_desc = to_nd_desc(nvdimm_bus);
>  	struct acpi_nfit_desc *acpi_desc = to_acpi_desc(nd_desc);
>  
> -	return sprintf(buf, "%d\n", acpi_desc->scrub_mode);
> +	return sprintf(buf, "%u\n", acpi_desc->scrub_mode);
>  }
>  
>  /*
> @@ -967,7 +967,7 @@ static ssize_t scrub_show(struct device *dev,
>  	if (nd_desc) {
>  		struct acpi_nfit_desc *acpi_desc = to_acpi_desc(nd_desc);
>  
> -		rc = sprintf(buf, "%d%s", acpi_desc->scrub_count,
> +		rc = sprintf(buf, "%u%s", acpi_desc->scrub_count,
>  				(work_busy(&acpi_desc->work)) ? "+\n" : "\n");
>  	}
>  	device_unlock(dev);

looks ok,
would it be an option to move the "\n" into the format string ?
this is much more common (see sprintf() above).

re,
 wh