linux-kernel - Re: [PATCH] PCI: mvebu: Handle changes to the bridge windows while enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170130143418.GB25924@io.lakedaemon.net>
Date:   Mon, 30 Jan 2017 14:34:18 +0000
From:   Jason Cooper <jason@...edaemon.net>
To:     Bjorn Helgaas <helgaas@...nel.org>
Cc:     Jason Gunthorpe <jgunthorpe@...idianresearch.com>,
        Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>,
        linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
        Gregory CLEMENT <gregory.clement@...e-electrons.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] PCI: mvebu: Handle changes to the bridge windows while
 enabled

Hi Bjorn,

On Sat, Jan 28, 2017 at 03:17:28PM -0600, Bjorn Helgaas wrote:
> On Wed, Jan 11, 2017 at 12:30:55PM -0600, Bjorn Helgaas wrote:
> > On Mon, Dec 12, 2016 at 11:30:20AM -0700, Jason Gunthorpe wrote:
> > > The PCI core will write to the bridge window config multiple times
> > > while they are enabled. This can lead to mbus failures like:
> > > 
> > >  mvebu_mbus: cannot add window '4:e8', conflicts with another window
> > >  mvebu-pcie mbus:pex@...00000: Could not create MBus window at [mem 0xe0000000-0xe00fffff]: -22
> > > 
> > > For me this is happening during a hotplug cycle. The PCI core is
> > > not changing the values, just writing them twice while active.
> > > 
> > > The patch addresses the general case of any change to an active window,
> > > but not atomically. The code is slightly refactored so io and mem
> > > can share more of the window logic.
> > 
> > Looks good to me, but I'm waiting for an ack from Thomas or Jason (listed
> > as maintainers and already cc'd).
> 
> Ping, Thomas, Jason C?
> 
> > > Signed-off-by: Jason Gunthorpe <jgunthorpe@...idianresearch.com>
> > > ---
> > >  drivers/pci/host/pci-mvebu.c | 101 +++++++++++++++++++++++++------------------
> > >  1 file changed, 60 insertions(+), 41 deletions(-)

Sorry, been on travel and I think Thomas is on holiday.

Acked-by: Jason Cooper <jason@...edaemon.net>

thx,

Jason.