linux-kernel - Re: [PATCH v6 3/5] cpuidle:powernv: Add helper function to populate powernv idle states.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <871svlxl7w.fsf@concordia.ellerman.id.au>
Date:   Mon, 30 Jan 2017 14:47:31 +1100
From:   Michael Ellerman <mpe@...erman.id.au>
To:     "Gautham R. Shenoy" <ego@...ux.vnet.ibm.com>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Paul Mackerras <paulus@...ba.org>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Michael Neuling <mikey@...ling.org>,
        Vaidyanathan Srinivasan <svaidy@...ux.vnet.ibm.com>,
        "Shreyas B. Prabhu" <shreyasbp@...il.com>,
        Shilpasri G Bhat <shilpa.bhat@...ux.vnet.ibm.com>,
        Stewart Smith <stewart@...ux.vnet.ibm.com>,
        Balbir Singh <bsingharora@...il.com>,
        Oliver O'Halloran <oohall@...il.com>,
        Rob Herring <robh+dt@...nel.org>
Cc:     linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
        linux-pm@...r.kernel.org, devicetree@...r.kernel.org,
        mark.rutland@....com, "Gautham R. Shenoy" <ego@...ux.vnet.ibm.com>
Subject: Re: [PATCH v6 3/5] cpuidle:powernv: Add helper function to populate powernv idle states.

"Gautham R. Shenoy" <ego@...ux.vnet.ibm.com> writes:

> From: "Gautham R. Shenoy" <ego@...ux.vnet.ibm.com>
>
> In the current code for powernv_add_idle_states, there is a lot of code
> duplication while initializing an idle state in powernv_states table.
>
> Add an inline helper function to populate the powernv_states[] table
> for a given idle state. Invoke this for populating the "Nap",
> "Fastsleep" and the stop states in powernv_add_idle_states.
>
> Acked-by: Balbir Singh <bsingharora@...il.com>
> Signed-off-by: Gautham R. Shenoy <ego@...ux.vnet.ibm.com>
> ---
>  drivers/cpuidle/cpuidle-powernv.c | 89 +++++++++++++++++++++++----------------
>  include/linux/cpuidle.h           |  1 +

I was going to merge this, but I see you've touched cpuidle.h, so I feel
like I should get an ACK from the cpuidle folks.

It's a fairly uncontroversial change, but it's their API.

cheers


> diff --git a/include/linux/cpuidle.h b/include/linux/cpuidle.h
> index da346f2..fc1e5d7 100644
> --- a/include/linux/cpuidle.h
> +++ b/include/linux/cpuidle.h
> @@ -62,6 +62,7 @@ struct cpuidle_state {
>  };
>  
>  /* Idle State Flags */
> +#define CPUIDLE_FLAG_NONE       (0x00)
>  #define CPUIDLE_FLAG_COUPLED	(0x02) /* state applies to multiple cpus */
>  #define CPUIDLE_FLAG_TIMER_STOP (0x04)  /* timer is stopped on this state */
>  
> -- 
> 1.9.4