linux-kernel - Re: [PATCH v4 1/2] mm/migration: make isolate_movable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170130151331.GA5311@dhcp22.suse.cz>
Date:   Mon, 30 Jan 2017 16:13:32 +0100
From:   Michal Hocko <mhocko@...nel.org>
To:     Yisheng Xie <ysxie@...mail.com>, akpm@...ux-foundation.org
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        n-horiguchi@...jp.nec.com, minchan@...nel.org, vbabka@...e.cz,
        guohanjun@...wei.com, qiuxishi@...wei.com
Subject: Re: [PATCH v4 1/2] mm/migration: make isolate_movable_page always
 defined

On Mon 30-01-17 22:59:52, Yisheng Xie wrote:
> Hi， Michal，
> Sorry for late reply.
> 
> On 01/26/2017 05:18 PM, Michal Hocko wrote:
> > On Wed 25-01-17 23:05:37, ysxie@...mail.com wrote:
> >> From: Yisheng Xie <xieyisheng1@...wei.com>
> >>
> >> Define isolate_movable_page as a static inline function when
> >> CONFIG_MIGRATION is not enable. It should return false
> >> here which means failed to isolate movable pages.
> >>
> >> This patch do not have any functional change but prepare for
> >> later patch.
> > I think it would make more sense to make isolate_movable_page return int
> > and have the same semantic as __isolate_lru_page. This would be a better
> > preparatory patch for the later work.
> Yes, I think you are right, it is better to make isolate_movable_page return int
> just as what isolate_lru_page do, to make a better code style.
> 
> It seems Andrew had already merged the fixed patch from Arnd Bergmann,
> Maybe I can rewrite it in a later patch if it is suitable :)

I guess Andrew can just drop the current series with the folow up fixes
and wait for your newer version.
-- 
Michal Hocko
SUSE Labs