linux-kernel - Re: [PATCH] video/mbx: use simple

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <13269025.Q9kkMo78lp@amdc3058>
Date:   Mon, 30 Jan 2017 17:22:23 +0100
From:   Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
To:     Geliang Tang <geliangtang@...il.com>
Cc:     linux-fbdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] video/mbx: use simple_open()


Hi,

On Friday, January 20, 2017 10:27:05 PM Geliang Tang wrote:
> Drop open_file_generic(), use simple_open() instead of it.
> 
> Signed-off-by: Geliang Tang <geliangtang@...il.com>

Thanks, patch queued for 4.11.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

> ---
>  drivers/video/fbdev/mbx/mbxdebugfs.c | 18 ++++++------------
>  1 file changed, 6 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/video/fbdev/mbx/mbxdebugfs.c b/drivers/video/fbdev/mbx/mbxdebugfs.c
> index e3bc00a..2528d3e 100644
> --- a/drivers/video/fbdev/mbx/mbxdebugfs.c
> +++ b/drivers/video/fbdev/mbx/mbxdebugfs.c
> @@ -15,12 +15,6 @@ struct mbxfb_debugfs_data {
>  	struct dentry *misc;
>  };
>  
> -static int open_file_generic(struct inode *inode, struct file *file)
> -{
> -	file->private_data = inode->i_private;
> -	return 0;
> -}
> -
>  static ssize_t write_file_dummy(struct file *file, const char __user *buf,
>  				size_t count, loff_t *ppos)
>  {
> @@ -174,42 +168,42 @@ static ssize_t misc_read_file(struct file *file, char __user *userbuf,
>  static const struct file_operations sysconf_fops = {
>  	.read = sysconf_read_file,
>  	.write = write_file_dummy,
> -	.open = open_file_generic,
> +	.open = simple_open,
>  	.llseek = default_llseek,
>  };
>  
>  static const struct file_operations clock_fops = {
>  	.read = clock_read_file,
>  	.write = write_file_dummy,
> -	.open = open_file_generic,
> +	.open = simple_open,
>  	.llseek = default_llseek,
>  };
>  
>  static const struct file_operations display_fops = {
>  	.read = display_read_file,
>  	.write = write_file_dummy,
> -	.open = open_file_generic,
> +	.open = simple_open,
>  	.llseek = default_llseek,
>  };
>  
>  static const struct file_operations gsctl_fops = {
>  	.read = gsctl_read_file,
>  	.write = write_file_dummy,
> -	.open = open_file_generic,
> +	.open = simple_open,
>  	.llseek = default_llseek,
>  };
>  
>  static const struct file_operations sdram_fops = {
>  	.read = sdram_read_file,
>  	.write = write_file_dummy,
> -	.open = open_file_generic,
> +	.open = simple_open,
>  	.llseek = default_llseek,
>  };
>  
>  static const struct file_operations misc_fops = {
>  	.read = misc_read_file,
>  	.write = write_file_dummy,
> -	.open = open_file_generic,
> +	.open = simple_open,
>  	.llseek = default_llseek,
>  };