linux-kernel - Re: [PATCH 001] staging: wlan-ng: Add tabstop preceding the statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170130164423.GA12941@kroah.com>
Date:   Mon, 30 Jan 2017 17:44:23 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Maksymilian Piechota <maksymilianpiechota@...il.com>
Cc:     linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org
Subject: Re: [PATCH 001] staging: wlan-ng: Add tabstop preceding the statement

On Mon, Jan 30, 2017 at 11:31:42AM -0500, Maksymilian Piechota wrote:
> This patch fixes the checkpatch.pl warning:
> 
> WARNING: Statements should start on a tabstop
> 
> Signed-off-by: Maksymilian Piechota <maksymilianpiechota@...il.com>
> ---
>  drivers/staging/wlan-ng/prism2mgmt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/wlan-ng/prism2mgmt.c b/drivers/staging/wlan-ng/prism2mgmt.c
> index 16fb2d3..2d67125 100644
> --- a/drivers/staging/wlan-ng/prism2mgmt.c
> +++ b/drivers/staging/wlan-ng/prism2mgmt.c
> @@ -1308,7 +1308,7 @@ int prism2mgmt_wlansniff(struct wlandevice *wlandev, void *msgp)
>  			hw->sniffhdr = 0;
>  			wlandev->netdev->type = ARPHRD_IEEE80211_PRISM;
>  		} else
> -		    if ((msg->wlanheader.status ==
> +			if ((msg->wlanheader.status ==
>  			 P80211ENUM_msgitem_status_data_ok)
>  			&& (msg->wlanheader.data == P80211ENUM_truth_true)) {
>  			hw->sniffhdr = 1;

Hm, this all doesn't look correct now, does it?  Please fix up the whole
if statement here.

thanks,

greg k-h