linux-kernel - Re: [PATCH] Dma - Fix possible NULL derefrence.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170130164954.GE19244@localhost>
Date:   Mon, 30 Jan 2017 22:19:54 +0530
From:   Vinod Koul <vinod.koul@...el.com>
To:     Shailendra Verma <shailendra.v@...sung.com>
Cc:     Dan Williams <dan.j.williams@...el.com>, dmaengine@...r.kernel.org,
        linux-kernel@...r.kernel.org, p.shailesh@...sung.com,
        ashish.kalra@...sung.com,
        Shailendra Verma <shailendra.capricorn@...il.com>
Subject: Re: [PATCH] Dma - Fix possible NULL derefrence.

On Fri, Jan 27, 2017 at 04:55:59PM +0530, Shailendra Verma wrote:
> of_match_device could return NULL, and so cause a NULL
> pointer dereference later.

Why is this tagged Dma - ....

Please look at he git log for the file before coming up with random tags

Worst part, this patch fails to apply, so which was this generated against?

> 
> Signed-off-by: Shailendra Verma <shailendra.v@...sung.com>
> ---
>  drivers/dma/mv_xor.c |    5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/mv_xor.c b/drivers/dma/mv_xor.c
> index 23f7528..c25b3bb 100644
> --- a/drivers/dma/mv_xor.c
> +++ b/drivers/dma/mv_xor.c
> @@ -1323,7 +1323,10 @@ static int mv_xor_probe(struct platform_device *pdev)
>  		const struct of_device_id *of_id =
>  			of_match_device(mv_xor_dt_ids,
>  					&pdev->dev);
> +		if (!of_id) {
> +			dev_err(&pdev->dev, "Error: No device match found\n");
> +			return -ENODEV;
> +		}
>  		xordev->xor_type = (uintptr_t)of_id->data;
>  	}
>  
> -- 
> 1.7.9.5
> 

-- 
~Vinod