linux-kernel - Re: [PATCH] PCI: ACPI: Fix ThunderX PEM initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e92355e7-634f-dc91-4716-da73a23b406c@caviumnetworks.com>
Date:   Mon, 30 Jan 2017 09:39:30 -0800
From:   David Daney <ddaney@...iumnetworks.com>
To:     Vadim Lomovtsev <Vadim.Lomovtsev@...iumnetworks.com>,
        <tn@...ihalf.com>, <David.Daney@...ium.com>, <bhelgaas@...gle.com>,
        <linux-pci@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>,
        <stemerkhanov@...IUMNETWORKS.onmicrosoft.com>
Subject: Re: [PATCH] PCI: ACPI: Fix ThunderX PEM initialization

On 01/30/2017 08:25 AM, Vadim Lomovtsev wrote:
> This patch is to address PEM initialization issue
> which causes network issues.
>
> It is necessary to search for _HID:PNP0A08 while requesting
> PEM resources via ACPI instead of "THRX0002".

Since this is fixing new code, there should be no chance to break 
previously working systems.

Bjorn: If possible, this should be merged for v4.10

>
> Signed-off-by: Vadim Lomovtsev <Vadim.Lomovtsev@...iumnetworks.com>

Acked-by: David Daney <david.daney@...ium.com>


> ---
>  drivers/pci/host/pci-thunder-pem.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/host/pci-thunder-pem.c b/drivers/pci/host/pci-thunder-pem.c
> index af722eb..aec30b8 100644
> --- a/drivers/pci/host/pci-thunder-pem.c
> +++ b/drivers/pci/host/pci-thunder-pem.c
> @@ -331,7 +331,7 @@ static int thunder_pem_acpi_init(struct pci_config_window *cfg)
>  	if (!res_pem)
>  		return -ENOMEM;
>
> -	ret = acpi_get_rc_resources(dev, "THRX0002", root->segment, res_pem);
> +	ret = acpi_get_rc_resources(dev, "PNP0A08", root->segment, res_pem);
>  	if (ret) {
>  		dev_err(dev, "can't get rc base address\n");
>  		return ret;
>