linux-kernel - Re: [PATCH 3/6] ARCv2: IRQ: Add macro for the first external interrupt number

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3ebcd0b6-d136-66fb-ef1f-ffc767767bc4@synopsys.com>
Date:   Mon, 30 Jan 2017 11:01:27 -0800
From:   Vineet Gupta <Vineet.Gupta1@...opsys.com>
To:     Yuriy Kolerov <yuriy.kolerov@...opsys.com>,
        <linux-snps-arc@...ts.infradead.org>
CC:     <marc.zyngier@....com>, <Alexey.Brodkin@...opsys.com>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/6] ARCv2: IRQ: Add macro for the first external
 interrupt number

On 01/27/2017 04:01 PM, Yuriy Kolerov wrote:
> Signed-off-by: Yuriy Kolerov <yuriy.kolerov@...opsys.com>

Please squash this with patch 5/6 !

> ---
>  arch/arc/include/asm/irq.h   | 1 +
>  arch/arc/kernel/intc-arcv2.c | 2 +-
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arc/include/asm/irq.h b/arch/arc/include/asm/irq.h
> index c0fa0d2..e61ad30 100644
> --- a/arch/arc/include/asm/irq.h
> +++ b/arch/arc/include/asm/irq.h
> @@ -16,6 +16,7 @@
>  #ifdef CONFIG_ISA_ARCV2
>  #define IPI_IRQ		19
>  #define SOFTIRQ_IRQ	21
> +#define FIRST_EXT_IRQ	24
>  #endif
>  
>  #include <linux/interrupt.h>
> diff --git a/arch/arc/kernel/intc-arcv2.c b/arch/arc/kernel/intc-arcv2.c
> index 2f31bb1..a9a7497 100644
> --- a/arch/arc/kernel/intc-arcv2.c
> +++ b/arch/arc/kernel/intc-arcv2.c
> @@ -98,7 +98,7 @@ static int arcv2_irq_map(struct irq_domain *d, unsigned int irq,
>  	 * core intc IRQs [16, 23]:
>  	 * Statically assigned always private-per-core (Timers, WDT, IPI, PCT)
>  	 */
> -	if (hw < 24) {
> +	if (hw < FIRST_EXT_IRQ) {
>  		/*
>  		 * A subsequent request_percpu_irq() fails if percpu_devid is
>  		 * not set. That in turns sets NOAUTOEN, meaning each core needs
>