[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20170130200825.buzj7dh2jfyovoyv@rob-hp-laptop>
Date: Mon, 30 Jan 2017 14:08:25 -0600
From: Rob Herring <robh@...nel.org>
To: Eugeniy Paltsev <Eugeniy.Paltsev@...opsys.com>
Cc: dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org,
devicetree@...r.kernel.org, linux-snps-arc@...ts.infradead.org,
Dan Williams <dan.j.williams@...el.com>,
Vinod Koul <vinod.koul@...el.com>,
Mark Rutland <mark.rutland@....com>,
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
Alexey Brodkin <Alexey.Brodkin@...opsys.com>
Subject: Re: [PATCH 1/2] dt-bindings: Document the Synopsys DW AXI DMA
bindings
On Wed, Jan 25, 2017 at 06:34:16PM +0300, Eugeniy Paltsev wrote:
> This patch adds documentation of device tree bindings for the Synopsys
> DesignWare AXI DMA controller.
>
> Signed-off-by: Eugeniy Paltsev <Eugeniy.Paltsev@...opsys.com>
> ---
> .../devicetree/bindings/dma/snps,axi-dw-dmac.txt | 33 ++++++++++++++++++++++
> 1 file changed, 33 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/dma/snps,axi-dw-dmac.txt
>
> diff --git a/Documentation/devicetree/bindings/dma/snps,axi-dw-dmac.txt b/Documentation/devicetree/bindings/dma/snps,axi-dw-dmac.txt
> new file mode 100644
> index 0000000..21318a7
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/dma/snps,axi-dw-dmac.txt
> @@ -0,0 +1,33 @@
> +* Synopsys DesignWare AXI DMA Controller
> +
> +Required properties:
> +- compatible: "snps,axi-dma"
Too generic. This needs an IP version at least.
> +- reg: Address range of the DMAC registers. This should include
> + all of the per-channel registers.
> +- interrupt: Should contain the DMAC interrupt number.
> +- interrupt-parent: Should be the phandle for the interrupt controller
> + that services interrupts for this device.
> +- dma-channels: Number of channels supported by hardware.
> +- dma-masters: Number of AXI masters supported by the hardware.
> +- data-width: Maximum AXI data width supported by hardware.
> + (0 - 8bits, 1 - 16bits, 2 - 32bits, ..., 6 - 512bits)
> +- priority: Priority of channel. Array property. Priority value must be
> + programmed within [0:dma-channels-1] range. (0 - minimum priority)
> +- block-size: Maximum block size supported by the controller channel. Array
> + property.
Array size equal to the number of dma-channels?
Other than dma-channels, all these either need vendor prefix.
> +
> +Example:
> +
> +dmac: dmac@...00 {
dma-controller@...
> + compatible = "snps,axi-dma";
> + reg = <0x80000 0x400>;
> + clocks = <&core_clk>;
> + interrupt-parent = <&intc>;
> + interrupts = <27>;
> +
> + dma-channels = <4>;
> + dma-masters = <2>;
> + data-width = <3>;
> + block-size = <4096 4096 4096 4096>;
> + priority = <0 1 2 3>;
> +};
> --
> 2.5.5
>
Powered by blists - more mailing lists