linux-kernel - Re: [PATCH] phy: qcom-ufs: Fix misplaced jump label

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <588B01BB.6050206@ti.com>
Date:   Fri, 27 Jan 2017 13:45:55 +0530
From:   Kishon Vijay Abraham I <kishon@...com>
To:     Vivek Gautam <vivek.gautam@...eaurora.org>
CC:     <linux-kernel@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>,
        Subhash Jadavani <subhashj@...eaurora.org>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        <stable@...r.kernel.org>
Subject: Re: [PATCH] phy: qcom-ufs: Fix misplaced jump label



On Friday 27 January 2017 01:40 PM, Vivek Gautam wrote:
> We want to skip only tx/rx_iface clocks and not ref_clk_src
> as well. Fix the jump label accordingly.
> 
> Fixes: 300f96771d78 ("phy: qcom-ufs: Skip obtaining rx/tx_iface_clk for msm8996 based phy")

merged, thanks.

-Kishon
> 
> Cc: Subhash Jadavani <subhashj@...eaurora.org>
> Cc: Martin K. Petersen <martin.petersen@...cle.com>
> Cc: Kishon Vijay Abraham I <kishon@...com>
> Cc: stable@...r.kernel.org
> Signed-off-by: Vivek Gautam <vivek.gautam@...eaurora.org>
> ---
> 
> Based on linux-phy next.
> 
>  drivers/phy/phy-qcom-ufs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/phy/phy-qcom-ufs.c b/drivers/phy/phy-qcom-ufs.c
> index c69568b8543d..1aee8723a682 100644
> --- a/drivers/phy/phy-qcom-ufs.c
> +++ b/drivers/phy/phy-qcom-ufs.c
> @@ -189,12 +189,12 @@ int ufs_qcom_phy_init_clks(struct ufs_qcom_phy *phy_common)
>  	if (err)
>  		goto out;
>  
> +skip_txrx_clk:
>  	err = ufs_qcom_phy_clk_get(phy_common->dev, "ref_clk_src",
>  				   &phy_common->ref_clk_src);
>  	if (err)
>  		goto out;
>  
> -skip_txrx_clk:
>  	/*
>  	 * "ref_clk_parent" is optional hence don't abort init if it's not
>  	 * found.
>