linux-kernel - Re: [PATCH] regulator: cpcap: Add basic regulator support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170131220953.GF7403@atomide.com>
Date:   Tue, 31 Jan 2017 14:09:53 -0800
From:   Tony Lindgren <tony@...mide.com>
To:     Mark Brown <broonie@...nel.org>
Cc:     Liam Girdwood <lgirdwood@...il.com>, linux-kernel@...r.kernel.org,
        linux-omap@...r.kernel.org, devicetree@...r.kernel.org,
        Marcel Partap <mpartap@....net>,
        Michael Scott <michael.scott@...aro.org>
Subject: Re: [PATCH] regulator: cpcap: Add basic regulator support

* Mark Brown <broonie@...nel.org> [170131 13:14]:
> On Mon, Jan 30, 2017 at 04:12:41PM -0800, Tony Lindgren wrote:
> > +	error = regmap_update_bits(rdev->regmap, rdev->desc->enable_reg,
> > +				   rdev->desc->enable_mask,
> > +				   rdev->desc->enable_val);
> > +	if (error)
> > +		return error;
> > +
> > +	if (rdev->desc->enable_val & CPCAP_REG_OFF_MODE_SEC) {
> > +		error = regmap_update_bits(rdev->regmap, regulator->assign_reg,
> > +					   regulator->assign_mask,
> > +					   regulator->assign_mask);
> > +		if (error)
> > +			return error;
> > +	}
> 
> What does this second register bit do?

My guess is that it triggers regulator idle modes in the PMIC based
on the SoC off mode. There's no documentation for this thing..

I've just kept what the Motorola Linux kernel tree does here and added
some comments to CPCAP_REG_OFF_MODE_SEC.

I'll address the rest of the comments and post v2, thanks for looking.

Regards,

Tony