linux-kernel - Re: [PATCH 09/17] net: stmmac: replace ENOSYS by EINVAL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 31 Jan 2017 11:06:10 +0100
From:   Giuseppe CAVALLARO <peppe.cavallaro@...com>
To:     Corentin Labbe <clabbe.montjoie@...il.com>,
        <alexandre.torgue@...com>, <netdev@...r.kernel.org>
CC:     <davem@...emloft.net>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 09/17] net: stmmac: replace ENOSYS by EINVAL

On 1/31/2017 10:11 AM, Corentin Labbe wrote:
> As said by checkpatch ENOSYS means 'invalid syscall nr' and nothing
> else.
> This patch replace ENOSYS by the more appropriate value EINVAL.
>
> Signed-off-by: Corentin Labbe <clabbe.montjoie@...il.com>

Acked-by: Giuseppe Cavallaro <peppe.cavallaro@...com>

> ---
>  drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> index eff6282..485b1cd 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> @@ -353,7 +353,7 @@ void stmmac_remove_config_dt(struct platform_device *pdev,
>  struct plat_stmmacenet_data *
>  stmmac_probe_config_dt(struct platform_device *pdev, const char **mac)
>  {
> -	return ERR_PTR(-ENOSYS);
> +	return ERR_PTR(-EINVAL);
>  }
>
>  void stmmac_remove_config_dt(struct platform_device *pdev,
>