linux-kernel - [PATCH -next] platform: x86: fix silead

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <8c34389b-9ea3-88af-7d63-db1ca746083b@infradead.org>
Date:   Mon, 30 Jan 2017 16:44:17 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Platform Driver <platform-driver-x86@...r.kernel.org>,
        Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>
Cc:     Hans de Goede <hdegoede@...hat.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: [PATCH -next] platform: x86: fix silead_dmi build error and depends

From: Randy Dunlap <rdunlap@...radead.org>

This driver cannot be built as a loadable module, so it should not
be built unless I2C=y and INPUT=y.

Fixes this build error:
drivers/built-in.o: In function `silead_ts_dmi_init':
silead_dmi.c:(.init.text+0xf00e): undefined reference to `i2c_bus_type'

Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
Cc: Hans de Goede <hdegoede@...hat.com>
---
 drivers/platform/x86/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

I don't see why the "depends on INPUT" was there at all,
but I modified its requirement anyway.  Maybe it can be removed...

--- linux-next-20170130.orig/drivers/platform/x86/Kconfig
+++ linux-next-20170130/drivers/platform/x86/Kconfig
@@ -1079,7 +1079,7 @@ config INTEL_TURBO_MAX_3
 
 config SILEAD_DMI
 	bool "Tablets with Silead touchscreens"
-	depends on ACPI && DMI && I2C && INPUT
+	depends on ACPI && DMI && I2C=y && INPUT=y
 	---help---
 	  Certain ACPI based tablets with Silead touchscreens do not have
 	  enough data in ACPI tables for the touchscreen driver to handle