linux-kernel - Re: [PATCH 00/17] net: stmmac: misc fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 31 Jan 2017 11:33:53 +0100
From:   Giuseppe CAVALLARO <peppe.cavallaro@...com>
To:     Joao Pinto <Joao.Pinto@...opsys.com>,
        Corentin Labbe <clabbe.montjoie@...il.com>,
        <alexandre.torgue@...com>, <netdev@...r.kernel.org>
CC:     <davem@...emloft.net>, <linux-kernel@...r.kernel.org>,
        Lars Persson <lars.persson@...s.com>
Subject: Re: [PATCH 00/17] net: stmmac: misc fix

On 1/31/2017 11:23 AM, Joao Pinto wrote:
>
> Hi Peppe,
>
> Às 10:00 AM de 1/31/2017, Giuseppe CAVALLARO escreveu:
>> Hello Corentin
>>
>> On 1/31/2017 10:11 AM, Corentin Labbe wrote:
>>> Hello
>>>
>>> I am currently working on dwmac-sun8i glue driver for Allwinner H3/A83T/A64.
>>> This serie is the result of all minor problem found in the stmmac driver.
>>
>> thank for this effort, many changes are to tidy up some part of the code
>> so  I wonder if these should stay on top of net-next.
>> There is on-going a thread to change something in the stmmac (where I
>> missed more details and I tried to refresh all asap); so added on copy
>> Joao.
>
> I submitted 2 suggestions that would rename folder stmicro to dwc and dwmac4*
> files to eqos. The second one is important, since there is no dwmc4/gmac4 core,
> in fact it is called eqos that will have 5.00 version very soon. Both
> suggestions were rejected and so I turned to developing features.
> I am available to discuss with you any improvement on these aspects if you think
> it makes sense.
>
> Currently I am developing the support for multi-queues / multi-channels which
> will enable in the future stmmac to be used in QAv and TSN applications.

this is a really good point, so I am happy that you are looking for this
supports that can stay on high priority and do not generate conflicts
with this patch series.

We will reopen the renaming story later... I hope to be more reactive
on that and sorry for my absence.

Regards
Peppe

>
> Thanks,
> Joao
>
>>
>> I will give you my feedback on some patches too.
>>
>> peppe
>>
>>> Regards
>>>
>>> Corentin Labbe (17):
>>>   net: stmmac: fix the typo on MAC_RNABLE_RX
>>>   net: stmmac: Remove the bus_setup function pointer
>>>   net: stmmac: fix some typos in comments
>>>   net: stmmac: remove freesoftware address
>>>   net: stmmac: remplace asm/io.h by linux/io.h
>>>   net: stmmac: fix some code style problem
>>>   net: stmmac: replace stmmac_mdio_busy_wait by readl_poll_timeout
>>>   net: stmmac: Use readl_poll_timeout
>>>   net: stmmac: replace ENOSYS by EINVAL
>>>   net: stmmac: Correct the error message about invalid speed
>>>   net: stmmac: Rewrite two test against NULL value
>>>   net: stmmac: rename rx_crc to rx_crc_errors
>>>   net: stmmac: Implement NAPI for TX
>>>   net: stmmac: print phy information
>>>   net: stmmac: remove dead code in stmmac_tx_clean
>>>   net: stmmac: remove unused variable in sysfs_display_ring
>>>   net: stmmac: replace unsigned by u32
>>>
>>>  drivers/net/ethernet/stmicro/stmmac/chain_mode.c   |  4 --
>>>  drivers/net/ethernet/stmicro/stmmac/common.h       |  8 +--
>>>  drivers/net/ethernet/stmicro/stmmac/descs.h        |  4 --
>>>  drivers/net/ethernet/stmicro/stmmac/descs_com.h    |  4 --
>>>  drivers/net/ethernet/stmicro/stmmac/dwmac100.h     |  4 --
>>>  drivers/net/ethernet/stmicro/stmmac/dwmac1000.h    |  4 --
>>>  .../net/ethernet/stmicro/stmmac/dwmac1000_core.c   |  4 --
>>>  .../net/ethernet/stmicro/stmmac/dwmac1000_dma.c    |  4 --
>>>  .../net/ethernet/stmicro/stmmac/dwmac100_core.c    |  4 --
>>>  drivers/net/ethernet/stmicro/stmmac/dwmac100_dma.c |  4 --
>>>  drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c |  2 +-
>>>  drivers/net/ethernet/stmicro/stmmac/dwmac_dma.h    |  4 --
>>>  drivers/net/ethernet/stmicro/stmmac/dwmac_lib.c    | 28 ++++------
>>>  drivers/net/ethernet/stmicro/stmmac/enh_desc.c     |  6 +--
>>>  drivers/net/ethernet/stmicro/stmmac/mmc.h          |  4 --
>>>  drivers/net/ethernet/stmicro/stmmac/mmc_core.c     |  4 --
>>>  drivers/net/ethernet/stmicro/stmmac/norm_desc.c    |  6 +--
>>>  drivers/net/ethernet/stmicro/stmmac/ring_mode.c    |  4 --
>>>  drivers/net/ethernet/stmicro/stmmac/stmmac.h       |  4 --
>>>  .../net/ethernet/stmicro/stmmac/stmmac_ethtool.c   |  6 +--
>>>  .../net/ethernet/stmicro/stmmac/stmmac_hwtstamp.c  |  4 --
>>>  drivers/net/ethernet/stmicro/stmmac/stmmac_main.c  | 63 ++++++++++------------
>>>  drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c  | 52 +++++++-----------
>>>  drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c   |  4 --
>>>  .../net/ethernet/stmicro/stmmac/stmmac_platform.c  |  6 +--
>>>  drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c   |  4 --
>>>  drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.h   |  4 --
>>>  include/linux/stmmac.h                             |  1 -
>>>  28 files changed, 65 insertions(+), 185 deletions(-)
>>>
>>
>
>