lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 31 Jan 2017 11:21:51 +0100 From: Giuseppe CAVALLARO <peppe.cavallaro@...com> To: Corentin Labbe <clabbe.montjoie@...il.com>, <alexandre.torgue@...com>, <netdev@...r.kernel.org> CC: <davem@...emloft.net>, <linux-kernel@...r.kernel.org> Subject: Re: [PATCH 15/17] net: stmmac: remove dead code in stmmac_tx_clean On 1/31/2017 10:11 AM, Corentin Labbe wrote: > Since commit cf32deec16e4 ("stmmac: add tx_skbuff_dma to save descriptors used by PTP"), > the struct dma_desc *p in stmmac_tx_clean was not used at all. > > This patch remove this dead code. > > Signed-off-by: Corentin Labbe <clabbe.montjoie@...il.com> Acked-by: Giuseppe Cavallaro <peppe.cavallaro@...com> > --- > drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > index 3d52b8c..b494bc2 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > @@ -1124,13 +1124,6 @@ static void dma_free_tx_skbufs(struct stmmac_priv *priv) > int i; > > for (i = 0; i < DMA_TX_SIZE; i++) { > - struct dma_desc *p; > - > - if (priv->extend_desc) > - p = &((priv->dma_etx + i)->basic); > - else > - p = priv->dma_tx + i; > - > if (priv->tx_skbuff_dma[i].buf) { > if (priv->tx_skbuff_dma[i].map_as_page) > dma_unmap_page(priv->device, >
Powered by blists - more mailing lists