linux-kernel - Re: [PATCH 6/6] staging: bcm2835-v4l2: Apply spelling fixes from checkpatch.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1485826718.20550.14.camel@perches.com>
Date:   Mon, 30 Jan 2017 17:38:38 -0800
From:   Joe Perches <joe@...ches.com>
To:     Eric Anholt <eric@...olt.net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     devel@...verdev.osuosl.org, linux-media@...r.kernel.org,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-rpi-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 6/6] staging: bcm2835-v4l2: Apply spelling fixes from
 checkpatch.

On Mon, 2017-01-30 at 12:05 -0800, Eric Anholt wrote:
> Joe Perches <joe@...ches.com> writes:
> 
> > On Fri, 2017-01-27 at 13:55 -0800, Eric Anholt wrote:
> > > Generated with checkpatch.pl --fix-inplace and git add -p out of the
> > > results.
> > 
> > Maybe another.
> > 
> > > diff --git a/drivers/staging/media/platform/bcm2835/mmal-vchiq.c b/drivers/staging/media/platform/bcm2835/mmal-vchiq.c
> > 
> > []
> > > @@ -239,7 +239,7 @@ static int bulk_receive(struct vchiq_mmal_instance *instance,
> > >  		pr_err("buffer list empty trying to submit bulk receive\n");
> > >  
> > >  		/* todo: this is a serious error, we should never have
> > > -		 * commited a buffer_to_host operation to the mmal
> > > +		 * committed a buffer_to_host operation to the mmal
> > >  		 * port without the buffer to back it up (underflow
> > >  		 * handling) and there is no obvious way to deal with
> > >  		 * this - how is the mmal servie going to react when
> > 
> > Perhaps s/servie/service/ ?
> 
> I was trying to restrict this patch to just the fixes from checkpatch.

That's the wrong thing to do if you're fixing
spelling defects.  checkpatch is just one mechanism
to identify some, and definitely not all, typos and
spelling defects.

If you fixing, fix.  Don't just rely on the brainless
tools, use your decidedly non-mechanical brain.