lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 31 Jan 2017 14:20:02 +0100
From:   Linus Walleij <>
To:     Bartosz Golaszewski <>
Cc:     Alexandre Courbot <>,
        Bamvor Jian Zhang <>,
        "" <>,
        "" <>
Subject: Re: [PATCH 1/7] gpiolib: clean up includes

On Wed, Jan 25, 2017 at 4:34 PM, Bartosz Golaszewski
<> wrote:

> gpiolib.h uses enum gpiod_flags, but doesn't pull in gpio/consumer.h.
> Include it in gpiolib.h and don't include neither consumer.h nor
> driver.h from modules that already include gpiolib.h.

Nah.... .c files should include the headers representing the
symbols they use. Not rely on secondary inclusions.

Drivers should ideally *always* and *only*
include <linux/gpio/driver.h>. If they include other stuff,
that is just tautological icing on the cake.

So, I'm gonna drop this.

Linus Walleij

Powered by blists - more mailing lists