linux-kernel - Re: [PATCH] thermal/intel_powerclamp: Remove set-but-not-used variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170131082241.00d093fb@jacob-builder>
Date:   Tue, 31 Jan 2017 08:22:41 -0800
From:   Jacob Pan <jacob.jun.pan@...ux.intel.com>
To:     Augusto Mecking Caringi <augustocaringi@...il.com>
Cc:     Zhang Rui <rui.zhang@...el.com>,
        Eduardo Valentin <edubezval@...il.com>,
        "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        Petr Mladek <pmladek@...e.com>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
        jacob.jun.pan@...ux.intel.com
Subject: Re: [PATCH] thermal/intel_powerclamp: Remove set-but-not-used
 variables

On Mon, 30 Jan 2017 10:47:36 +0000
Augusto Mecking Caringi <augustocaringi@...il.com> wrote:

> In poll_pkg_cstate() function, the variables jiffies_last and
> jiffies_now are set but never used.
> 
> This has been detected by building the driver with W=1:
> 
> drivers/thermal/intel_powerclamp.c: In function ‘poll_pkg_cstate’:
> drivers/thermal/intel_powerclamp.c:464:23: warning: variable
> ‘jiffies_last’ set but not used [-Wunused-but-set-variable]
> static unsigned long jiffies_last;
>                        ^
> 
Acked-by: Jacob Pan <jacob.jun.pan@...ux.intel.com>

Thanks,
> Signed-off-by: Augusto Mecking Caringi <augustocaringi@...il.com>
> ---
>  drivers/thermal/intel_powerclamp.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/thermal/intel_powerclamp.c
> b/drivers/thermal/intel_powerclamp.c index df64692..a47103a 100644
> --- a/drivers/thermal/intel_powerclamp.c
> +++ b/drivers/thermal/intel_powerclamp.c
> @@ -461,16 +461,13 @@ static void poll_pkg_cstate(struct work_struct
> *dummy) {
>  	static u64 msr_last;
>  	static u64 tsc_last;
> -	static unsigned long jiffies_last;
>  
>  	u64 msr_now;
> -	unsigned long jiffies_now;
>  	u64 tsc_now;
>  	u64 val64;
>  
>  	msr_now = pkg_state_counter();
>  	tsc_now = rdtsc();
> -	jiffies_now = jiffies;
>  
>  	/* calculate pkg cstate vs tsc ratio */
>  	if (!msr_last || !tsc_last)
> @@ -485,7 +482,6 @@ static void poll_pkg_cstate(struct work_struct
> *dummy) 
>  	/* update record */
>  	msr_last = msr_now;
> -	jiffies_last = jiffies_now;
>  	tsc_last = tsc_now;
>  
>  	if (true == clamping)

[Jacob Pan]