linux-kernel - Re: [PATCH] mtd: spi-nor: cqspi: remove redundant dead code on error return check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <630cf780-6cf5-ff5d-1a83-e360074483b4@nod.at>
Date:   Tue, 31 Jan 2017 17:39:41 +0100
From:   Richard Weinberger <richard@....at>
To:     Colin King <colin.king@...onical.com>,
        Cyrille Pitchen <cyrille.pitchen@...el.com>,
        Marek Vasut <marek.vasut@...il.com>,
        David Woodhouse <dwmw2@...radead.org>,
        Brian Norris <computersforpeace@...il.com>,
        Boris Brezillon <boris.brezillon@...e-electrons.com>,
        linux-mtd@...ts.infradead.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mtd: spi-nor: cqspi: remove redundant dead code on error
 return check

Am 31.01.2017 um 16:53 schrieb Colin King:
> From: Colin Ian King <colin.king@...onical.com>
> 
> Checking for ret < 0 is redundant because a previous check on ret
> being non-zero already handles the ret < 0 case. Remove the redundant
> code. Found by CoverityScan, CID#1398863, CID#1398864
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Reviewed-by: Richard Weinberger <richard@....at>

Thanks,
//richard