lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 1 Feb 2017 02:29:42 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Loic Pallardy <loic.pallardy@...com>
Cc:     kbuild-all@...org, bjorn.andersson@...aro.org, ohad@...ery.com,
        lee.jones@...aro.org, loic.pallardy@...com,
        linux-remoteproc@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel@...inux.com, patrice.chotard@...com, hugues.fruchet@...com,
        peter.griffin@...aro.org
Subject: Re: [PATCH v2 5/6] rpmsg: virtio_rpmsg: don't allocate buffer if
 provided by low level driver

Hi Loic,

[auto build test WARNING on v4.9-rc8]
[also build test WARNING on next-20170130]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Loic-Pallardy/virtio_rpmsg-make-rpmsg-channel-configurable/20170131-212156
config: arm-allmodconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=arm 

Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings

All warnings (new ones prefixed by >>):

   In file included from arch/arm/include/asm/page.h:171:0,
                    from arch/arm/include/asm/thread_info.h:17,
                    from include/linux/thread_info.h:58,
                    from include/asm-generic/preempt.h:4,
                    from ./arch/arm/include/generated/asm/preempt.h:1,
                    from include/linux/preempt.h:59,
                    from include/linux/spinlock.h:50,
                    from include/linux/seqlock.h:35,
                    from include/linux/time.h:5,
                    from include/linux/stat.h:18,
                    from include/linux/module.h:10,
                    from drivers/rpmsg/virtio_rpmsg_bus.c:23:
   drivers/rpmsg/virtio_rpmsg_bus.c: In function 'rpmsg_probe':
>> include/asm-generic/getorder.h:17:6: warning: 'total_buf_space' may be used uninitialized in this function [-Wmaybe-uninitialized]
     size--;
     ~~~~^~
   drivers/rpmsg/virtio_rpmsg_bus.c:934:9: note: 'total_buf_space' was declared here
     size_t total_buf_space;
            ^~~~~~~~~~~~~~~
   In file included from drivers/rpmsg/virtio_rpmsg_bus.c:28:0:
>> include/linux/dma-mapping.h:481:6: warning: 'bufs_va' may be used uninitialized in this function [-Wmaybe-uninitialized]
     if (dma_release_from_coherent(dev, get_order(size), cpu_addr))
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/rpmsg/virtio_rpmsg_bus.c:932:8: note: 'bufs_va' was declared here
     void *bufs_va;
           ^~~~~~~

vim +/total_buf_space +17 include/asm-generic/getorder.h

5b17e1cd include/asm-generic/getorder.h Arnd Bergmann    2009-05-13   1  #ifndef __ASM_GENERIC_GETORDER_H
5b17e1cd include/asm-generic/getorder.h Arnd Bergmann    2009-05-13   2  #define __ASM_GENERIC_GETORDER_H
fd4fd5aa include/asm-generic/page.h     Stephen Rothwell 2005-09-03   3  
fd4fd5aa include/asm-generic/page.h     Stephen Rothwell 2005-09-03   4  #ifndef __ASSEMBLY__
fd4fd5aa include/asm-generic/page.h     Stephen Rothwell 2005-09-03   5  
38f33230 include/asm-generic/page.h     Linus Torvalds   2007-03-06   6  #include <linux/compiler.h>
d66acc39 include/asm-generic/getorder.h David Howells    2012-02-20   7  #include <linux/log2.h>
d66acc39 include/asm-generic/getorder.h David Howells    2012-02-20   8  
d66acc39 include/asm-generic/getorder.h David Howells    2012-02-20   9  /*
d66acc39 include/asm-generic/getorder.h David Howells    2012-02-20  10   * Runtime evaluation of get_order()
d66acc39 include/asm-generic/getorder.h David Howells    2012-02-20  11   */
d66acc39 include/asm-generic/getorder.h David Howells    2012-02-20  12  static inline __attribute_const__
d66acc39 include/asm-generic/getorder.h David Howells    2012-02-20  13  int __get_order(unsigned long size)
d66acc39 include/asm-generic/getorder.h David Howells    2012-02-20  14  {
d66acc39 include/asm-generic/getorder.h David Howells    2012-02-20  15  	int order;
d66acc39 include/asm-generic/getorder.h David Howells    2012-02-20  16  
d66acc39 include/asm-generic/getorder.h David Howells    2012-02-20 @17  	size--;
d66acc39 include/asm-generic/getorder.h David Howells    2012-02-20  18  	size >>= PAGE_SHIFT;
d66acc39 include/asm-generic/getorder.h David Howells    2012-02-20  19  #if BITS_PER_LONG == 32
d66acc39 include/asm-generic/getorder.h David Howells    2012-02-20  20  	order = fls(size);
d66acc39 include/asm-generic/getorder.h David Howells    2012-02-20  21  #else
d66acc39 include/asm-generic/getorder.h David Howells    2012-02-20  22  	order = fls64(size);
d66acc39 include/asm-generic/getorder.h David Howells    2012-02-20  23  #endif
d66acc39 include/asm-generic/getorder.h David Howells    2012-02-20  24  	return order;
d66acc39 include/asm-generic/getorder.h David Howells    2012-02-20  25  }

:::::: The code at line 17 was first introduced by commit
:::::: d66acc39c7cee323733c8503b9de1821a56dff7e bitops: Optimise get_order()

:::::: TO: David Howells <dhowells@...hat.com>
:::::: CC: H. Peter Anvin <hpa@...or.com>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (59452 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ