linux-kernel - Re: [PATCH] x86/mce: Make timer handling more robust

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170131183749.32ol7i7qnjfa35qx@pd.tnic>
Date:   Tue, 31 Jan 2017 19:37:49 +0100
From:   Borislav Petkov <bp@...en8.de>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     LKML <linux-kernel@...r.kernel.org>, x86@...nel.org,
        Erik Veijola <erik.veijola@...el.com>,
        Tony Luck <tony.luck@...el.com>
Subject: Re: [PATCH] x86/mce: Make timer handling more robust

On Tue, Jan 31, 2017 at 02:33:29PM +0100, Thomas Gleixner wrote:
> On Tue, 31 Jan 2017, Thomas Gleixner wrote:
> > +static void mce_start_timer(struct timer_list *t)
> >  {
> >  	unsigned long iv = check_interval * HZ;
> >  
> >  	if (mca_cfg.ignore_ce || !iv)
> >  		return;
> >  
> > -	per_cpu(mce_next_interval, cpu) = iv;
> > -
> > -	t->expires = round_jiffies(jiffies + iv);
> > -	add_timer_on(t, cpu);
> > +	this_cpu_write(mce_next_interval, iv);
> > +	__start_timer(t, jiffies + iv);
> 
> Bah. That's wrong. Delta patch below:
> 
> --- a/arch/x86/kernel/cpu/mcheck/mce.c
> +++ b/arch/x86/kernel/cpu/mcheck/mce.c
> @@ -1782,7 +1782,7 @@ static void mce_start_timer(struct timer
>  		return;
>  
>  	this_cpu_write(mce_next_interval, iv);
> -	__start_timer(t, jiffies + iv);
> +	__start_timer(t, iv);
>  }
>  
>  static void __mcheck_cpu_setup_timer(void)

With that hunk merged in:

Reviewed-by: Borislav Petkov <bp@...e.de>
Tested-by: Borislav Petkov <bp@...e.de>

Thanks!

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.