linux-kernel - Re: [PATCH] iio: stx104: Add support for GPIO names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5c284102-a0c6-8a47-e4ab-85bcb3511390@kernel.org>
Date:   Tue, 31 Jan 2017 18:55:22 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Linus Walleij <linus.walleij@...aro.org>,
        William Breathitt Gray <vilhelm.gray@...il.com>
Cc:     Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald <pmeerw@...erw.net>,
        "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] iio: stx104: Add support for GPIO names

On 31/01/17 09:41, Linus Walleij wrote:
> On Mon, Jan 30, 2017 at 6:16 PM, William Breathitt Gray
> <vilhelm.gray@...il.com> wrote:
> 
>> This patch sets the gpio_chip names option with an array of GPIO line
>> names that match the manual documentation for the Apex Embedded Systems
>> STX104. This should make it easier for users to identify which GPIO line
>> corresponds to a respective GPIO pin on the device.
>>
>> Signed-off-by: William Breathitt Gray <vilhelm.gray@...il.com>
> (...)
>> +#define STX104_NGPIO 8
>> +static const char *stx104_names[STX104_NGPIO] = {
>> +       "DIN0", "DIN1", "DIN2", "DIN3", "DOUT0", "DOUT1", "DOUT2", "DOUT3"
>> +};
> (...)
>> +       stx104gpio->chip.ngpio = STX104_NGPIO;
>> +       stx104gpio->chip.names = stx104_names;
> 
> If the device has a gpio-controller tagged node in a device tree, it is better
> to use gpio-line-names = "foo" ...; for this. For ACPI there is something
> similar.
> 
> If it is spawn from this device without any GPIO child node or hardware
> description outside of the kernel driver, such as
> ISA/PCI or whatever, this is a good way.
> 
> This is an isa_driver and falls in the latter category, so:
> Reviewed-by: Linus Walleij <linus.walleij@...aro.org>
Cool.. thanks for the info as well.

Applied to the togreg branch of iio.git. Will push out as testing in a few minutes
to let the autobuilders play with it.

Thanks,

Jonathan
> 
> Yours,
> Linus Walleij
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>