linux-kernel - Re: [PATCH] HID: add Asus macrokey support for Asus "Republic of Gamers" laptop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 1 Feb 2017 09:18:52 +0100
From:   Benjamin Tissoires <benjamin.tissoires@...hat.com>
To:     Daniel Drake <drake@...lessm.com>
Cc:     Chris Chiu <chiu@...lessm.com>, Jiri Kosina <jikos@...nel.org>,
        Linux Kernel <linux-kernel@...r.kernel.org>,
        linux-input@...r.kernel.org,
        Linux Upstreaming Team <linux@...lessm.com>
Subject: Re: [PATCH] HID: add Asus macrokey support for Asus "Republic of
 Gamers" laptop

On Jan 31 2017 or thereabouts, Daniel Drake wrote:
> Hi Benjamin,
> 
> On Tue, Dec 13, 2016 at 2:16 AM, Benjamin Tissoires
> <benjamin.tissoires@...hat.com> wrote:
> > On Dec 12 2016 or thereabouts, Chris Chiu wrote:
> >> ROG means ASUS "Republic of Gamers" laptops. The input device info
> >> also represents itself as "ASASTeK COMPUTER INC. ROG MacroKey". It
> >> uses special HID_USAGE code for function keys. This commit remap the
> >> special code to standard keycode for function keys handling. It's
> >> verified on GL553VD/VE, GL753VD/VE.
> >>
> >> Signed-off-by: Chris Chiu <chiu@...lessm.com>
> >> Reported-by: Yukai Li <yukaili@...il.com>
> >> ---
> >
> > Hi Chris,
> >
> > there is no real point of having a separate driver from hid-asus. The
> > HID tree prefer to group drivers by vendors, so these keyboards should
> > be supported through hid-asus.
> 
> Thanks for the feedback. We will submit a new version soon.
> 
> Just to confirm, hid-asus currently depends on I2C_HID. The new
> devices being quirked now are USB devices. With this patch should we
> now update it to depend on I2C_HID && USB_HID?
> 

Actually you can remove the I2C_HID dependency entirely (and not add one
for USB_HID). In the Kconfig, the modules are already guarded by a
"if HID", and there is nothing transport specific in hid-asus as far as
I can tell.

Note: we should also probably clean up the Kconfig once again and remove
all the "depends on HID" for those that are guarded by the if statement.

Cheers,
Benjamin