[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <87o9ym2sih.fsf@linux.intel.com>
Date: Wed, 01 Feb 2017 11:02:30 +0200
From: Felipe Balbi <balbi@...nel.org>
To: Greg KH <gregkh@...uxfoundation.org>,
Stefan Agner <stefan@...er.ch>
Cc: andrzej.p@...sung.com, linux-usb@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] fs: configfs: use hexadecimal values and new line
Hi,
Greg KH <gregkh@...uxfoundation.org> writes:
> On Tue, Jan 31, 2017 at 06:19:17PM -0800, Stefan Agner wrote:
>> Other unsigned properties return hexadecimal values, follow this
>> convention when printing b_vendor_code too. Also add newlines to
>> the OS Descriptor support related properties, like other sysfs
>> files use.
>
> configfs is not sysfs, so watch out, you might not need/want those new
> lines as tools read the values and are not expecting them.
>
> Have you verified that nothing will break with this? How have you
> tested it?
I would rather not change things like that, specially since Android guys
are alreadying using configfs.
--
balbi
Download attachment "signature.asc" of type "application/pgp-signature" (833 bytes)
Powered by blists - more mailing lists