linux-kernel - [tip:locking/core] sched/wake_q: Clarify queue reinit comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 1 Feb 2017 02:08:54 -0800
From:   tip-bot for Davidlohr Bueso <tipbot@...or.com>
To:     linux-tip-commits@...r.kernel.org
Cc:     dave@...olabs.net, hpa@...or.com, dbueso@...e.de,
        linux-kernel@...r.kernel.org, mingo@...nel.org, longman@...hat.com,
        tglx@...utronix.de
Subject: [tip:locking/core] sched/wake_q: Clarify queue reinit comment

Commit-ID:  0754445d71c37a7afd4f0790a9be4cf53c1b8cc4
Gitweb:     http://git.kernel.org/tip/0754445d71c37a7afd4f0790a9be4cf53c1b8cc4
Author:     Davidlohr Bueso <dave@...olabs.net>
AuthorDate: Sun, 29 Jan 2017 07:15:31 -0800
Committer:  Ingo Molnar <mingo@...nel.org>
CommitDate: Wed, 1 Feb 2017 10:02:18 +0100

sched/wake_q: Clarify queue reinit comment

As of:

  bcc9a76d5ac ("locking/rwsem: Reinit wake_q after use")

the comment regarding the list reinitialization no longer applies,
update it with the new wake_q_init() helper.

Signed-off-by: Davidlohr Bueso <dbueso@...e.de>
Acked-by: Waiman Long <longman@...hat.com>
Cc: peterz@...radead.org
Cc: longman@...hat.com
Cc: akpm@...ux-foundation.org
Cc: paulmck@...ux.vnet.ibm.com
Cc: torvalds@...ux-foundation.org
Link: http://lkml.kernel.org/r/20170129151531.GA2444@linux-80c1.suse
Signed-off-by: Ingo Molnar <mingo@...nel.org>
---
 include/linux/sched.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/sched.h b/include/linux/sched.h
index 4e62b37..1cc0ded 100644
--- a/include/linux/sched.h
+++ b/include/linux/sched.h
@@ -1000,8 +1000,8 @@ enum cpu_idle_type {
  *
  * The DEFINE_WAKE_Q macro declares and initializes the list head.
  * wake_up_q() does NOT reinitialize the list; it's expected to be
- * called near the end of a function, where the fact that the queue is
- * not used again will be easy to see by inspection.
+ * called near the end of a function. Otherwise, the list can be
+ * re-initialized for later re-use by wake_q_init().
  *
  * Note that this can cause spurious wakeups. schedule() callers
  * must ensure the call is done inside a loop, confirming that the