linux-kernel - Re: [PATCH] rtc: sun6i: extend test coverage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 1 Feb 2017 13:12:51 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     Alexandre Belloni <alexandre.belloni@...e-electrons.com>
Cc:     Alessandro Zummo <a.zummo@...ertech.it>,
        Maxime Ripard <maxime.ripard@...e-electrons.com>,
        rtc-linux@...glegroups.com,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] rtc: sun6i: extend test coverage

On Wed, Feb 1, 2017 at 12:57 PM, Alexandre Belloni
<alexandre.belloni@...e-electrons.com> wrote:
> COMPILE_TEST was wrongly placed, move it to the "depends on" line. Also,
> select COMMON_CLK has the driver now needs it to be properly compiled.
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@...e-electrons.com>
> ---
>  drivers/rtc/Kconfig | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
> index ee287cf63b01..06f3beb8e30f 100644
> --- a/drivers/rtc/Kconfig
> +++ b/drivers/rtc/Kconfig
> @@ -1435,8 +1435,9 @@ config RTC_DRV_SUN4V
>
>  config RTC_DRV_SUN6I
>         bool "Allwinner A31 RTC"
> -       default MACH_SUN6I || MACH_SUN8I || COMPILE_TEST
> -       depends on ARCH_SUNXI
> +       default MACH_SUN6I || MACH_SUN8I
> +       select COMMON_CLK

I think this needs to be "depends on COMMON_CLK", otherwise it looks good.

     Arnd