linux-kernel - Re: [PATCH 8/8] asus-wmi: Don't register rfkill if ASHS and user bit are present

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+A7VXWtaEcQWxJQdRxQOqB+EhU0YuVU4r4EjLWes8fwwVgY=Q@mail.gmail.com>
Date:   Wed, 1 Feb 2017 07:18:41 -0500
From:   João Paulo Rechi Vita <jprvita@...il.com>
To:     Joe Perches <joe@...ches.com>
Cc:     Corentin Chary <corentin.chary@...il.com>,
        Darren Hart <dvhart@...radead.org>,
        platform-driver-x86@...r.kernel.org,
        acpi4asus-user <acpi4asus-user@...ts.sourceforge.net>,
        LKML <linux-kernel@...r.kernel.org>, linux@...lessm.com,
        João Paulo Rechi Vita <jprvita@...lessm.com>
Subject: Re: [PATCH 8/8] asus-wmi: Don't register rfkill if ASHS and user bit
 are present

On 26 January 2017 at 17:45, Joe Perches <joe@...ches.com> wrote:
> On Thu, 2017-01-26 at 10:30 -0500, João Paulo Rechi Vita wrote:
>> Some Asus laptops that have an airplane-mode indicator LED, also have
>> the WMI WLAN user bit set, and the following bits in their DSDT:
>
> style trivia:
>
>> diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c
> []
>> @@ -2051,6 +2052,16 @@ static int asus_wmi_fan_init(struct asus_wmi *asus)
>>       return 0;
>>  }
>>
>> +static bool ashs_present(void)
>> +{
>> +     int i;
>> +
>> +     for (i = 0; strcmp(asus_wireless_ids[i].id, ""); i++)
>> +             if (acpi_dev_found(asus_wireless_ids[i].id))
>> +                     return true;
>
> The for loop would commonly have braces because of the
> internal if.
>

Thanks, I'm fixing it for the next revision.

--
João Paulo Rechi Vita
http://about.me/jprvita