lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CA+A7VXU2yjb6dYExqZjsP3--6ePJzK+nbNKADv=rxUcGfzX8pQ@mail.gmail.com>
Date:   Wed, 1 Feb 2017 07:24:20 -0500
From:   João Paulo Rechi Vita <jprvita@...il.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Darren Hart <dvhart@...radead.org>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        acpi4asus-user <acpi4asus-user@...ts.sourceforge.net>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        linux@...lessm.com,
        João Paulo Rechi Vita <jprvita@...lessm.com>
Subject: Re: [PATCH 1/1] asus-wireless: Fix identation

On 27 January 2017 at 10:28, Andy Shevchenko <andy.shevchenko@...il.com> wrote:
> On Thu, Jan 26, 2017 at 4:25 PM, João Paulo Rechi Vita
> <jprvita@...il.com> wrote:
>> Signed-off-by: João Paulo Rechi Vita <jprvita@...lessm.com>
>> ---
>>  drivers/platform/x86/asus-wireless.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/platform/x86/asus-wireless.c b/drivers/platform/x86/asus-wireless.c
>> index 9f31bc1a47d0..c9b5ac152cf1 100644
>> --- a/drivers/platform/x86/asus-wireless.c
>> +++ b/drivers/platform/x86/asus-wireless.c
>> @@ -77,7 +77,7 @@ static void led_state_update(struct work_struct *work)
>>  }
>>
>>  static void led_state_set(struct led_classdev *led,
>> -                                 enum led_brightness value)
>> +                         enum led_brightness value)
>
> I would see benefit if it would be one line.
>

Yes, I fixed this in a hurry and missed it actually fits in one line.
Thanks for catching it! I'll reply with an updated patch.

--
João Paulo Rechi Vita
http://about.me/jprvita

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ