linux-kernel - Re: [STLinux Kernel] [PATCH v2 05/10] serial: st-asc: Use generic DT binding for announcing RTS/CTS lines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170201145654.GD28760@griffinp-ThinkPad-X1-Carbon-2nd>
Date:   Wed, 1 Feb 2017 14:56:54 +0000
From:   Peter Griffin <peter.griffin@...aro.org>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     gregkh@...uxfoundation.org, jslaby@...e.com,
        linux-serial@...r.kernel.org, dt@...nel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, kernel@...inux.com
Subject: Re: [STLinux Kernel] [PATCH v2 05/10] serial: st-asc: Use generic DT
 binding for announcing RTS/CTS lines

On Wed, 01 Feb 2017, Lee Jones wrote:

> The initial binding 'st,hw-flow-control' isn't used anywhere, in neither
> in upstream nor downstream kernels.  It isn't even documented in
> dt-bindings, so we can safely assume it's safe to swap to the generic
> one.
> 
> Signed-off-by: Lee Jones <lee.jones@...aro.org>

Acked-by: Peter Griffin <peter.griffin@...aro.org>

> ---
>  drivers/tty/serial/st-asc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/st-asc.c b/drivers/tty/serial/st-asc.c
> index e521078..bcf1d33 100644
> --- a/drivers/tty/serial/st-asc.c
> +++ b/drivers/tty/serial/st-asc.c
> @@ -794,7 +794,7 @@ static struct asc_port *asc_of_get_asc_port(struct platform_device *pdev)
>  		return NULL;
>  
>  	asc_ports[id].hw_flow_control = of_property_read_bool(np,
> -							"st,hw-flow-control");
> +							"uart-has-rtscts");
>  	asc_ports[id].force_m1 =  of_property_read_bool(np, "st,force_m1");
>  	asc_ports[id].port.line = id;
>  	asc_ports[id].rts = NULL;