linux-kernel - Re: [PATCH 1/4] dt-bindings: Add binding for brcm,bcm2835-sdhost.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170201150252.gvoqp3eprj5bosvu@rob-hp-laptop>
Date:   Wed, 1 Feb 2017 09:02:52 -0600
From:   Rob Herring <robh@...nel.org>
To:     Gerd Hoffmann <kraxel@...hat.com>
Cc:     linux-rpi-kernel@...ts.infradead.org, ulf.hansson@...aro.org,
        mark.rutland@....com, f.fainelli@...il.com, rjui@...adcom.com,
        sbranden@...adcom.com, bcm-kernel-feedback-list@...adcom.com,
        swarren@...dotorg.org, lee@...nel.org, eric@...olt.net,
        linux@...linux.org.uk, linux-mmc@...r.kernel.org,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] dt-bindings: Add binding for brcm,bcm2835-sdhost.

On Fri, Jan 27, 2017 at 12:36:26PM +0100, Gerd Hoffmann wrote:
> From: Eric Anholt <eric@...olt.net>
> 
> This is the other SD controller on the platform, which can be swapped
> to the role of SD card host using pin muxing.
> 
> Signed-off-by: Eric Anholt <eric@...olt.net>
> ---
>  .../bindings/mmc/brcm,bcm2835-sdhost.txt           | 24 ++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mmc/brcm,bcm2835-sdhost.txt
> 
> diff --git a/Documentation/devicetree/bindings/mmc/brcm,bcm2835-sdhost.txt b/Documentation/devicetree/bindings/mmc/brcm,bcm2835-sdhost.txt
> new file mode 100644
> index 0000000..f9f5982
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mmc/brcm,bcm2835-sdhost.txt
> @@ -0,0 +1,24 @@
> +Broadcom BCM2835 SDHOST controller
> +
> +This file documents differences between the core properties described
> +by mmc.txt and the properties that represent the BCM2835 controller.
> +
> +Required properties:
> +- compatible: Should be "brcm,bcm2835-sdhost".
> +- clocks: The clock feeding the SDHOST controller.
> +
> +Optional properties:
> +- dmas: DMA channels for read and write.
> +          See Documentation/devicetree/bindings/dma/dma.txt for details
> +
> +Example:
> +
> +sdhost: sdhost@...02000 {

Node names should be the generic type of device, so:

mmc@...

With that,

Acked-by: Rob Herring <robh@...nel.org>