linux-kernel - Re: [PATCH] regulator: arizona-ldo1: constify regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170201150826.GR1754@localhost.localdomain>
Date:   Wed, 1 Feb 2017 15:08:26 +0000
From:   Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
To:     Bhumika Goyal <bhumirks@...il.com>
CC:     <julia.lawall@...6.fr>, <lgirdwood@...il.com>,
        <broonie@...nel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] regulator: arizona-ldo1: constify regulator_ops structure

On Sat, Jan 28, 2017 at 07:08:41PM +0530, Bhumika Goyal wrote:
> Declare regulator_ops structure as const as it is only stored in the ops
> field of a regulator_desc structure. This field is of type const, so
> regulator_ops structures having this property can be made const too.
> 
> File size before: drivers/regulator/arizona-ldo1.o
>    text	   data	    bss	    dec	    hex	filename
>    1890	    720	      0	   2610	    a32	drivers/regulator/arizona-ldo1.o
> 
> File size after: drivers/regulator/arizona-ldo1.o
>    text	   data	    bss	    dec	    hex	filename
>    2402	    192	      0	   2594	    a22	drivers/regulator/arizona-ldo1.o
> 
> Signed-off-by: Bhumika Goyal <bhumirks@...il.com>
> ---

Patch looks fine but CCing patches@...nsource.wolfsonmicro.com on
patches to the Arizona driver would be greatly appreciated.

Thanks,
Charles