linux-kernel - Re: [PATCHv7 2/8] printk: rename nmi.c and exported api

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 1 Feb 2017 10:50:56 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Sergey Senozhatsky <sergey.senozhatsky@...il.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Petr Mladek <pmladek@...e.com>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Jan Kara <jack@...e.cz>, Tejun Heo <tj@...nel.org>,
        Calvin Owens <calvinowens@...com>,
        Ingo Molnar <mingo@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Andy Lutomirski <luto@...nel.org>,
        Peter Hurley <peter@...leysoftware.com>,
        linux-kernel@...r.kernel.org,
        Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
Subject: Re: [PATCHv7 2/8] printk: rename nmi.c and exported api

On Wed, 1 Feb 2017 10:48:05 -0500
Steven Rostedt <rostedt@...dmis.org> wrote:

> On Tue, 27 Dec 2016 23:16:05 +0900
> Sergey Senozhatsky <sergey.senozhatsky@...il.com> wrote:
> 
> > A preparation patch for printk_safe work. No functional change.
> > - rename nmi.c to print_safe.c
> > - add `printk_safe' prefix to some (which used both by printk-safe
> >   and printk-nmi) of the exported functions.
> > 
> > Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@...il.com>  
> 
> Looks good.
> 
> Reviewed-by: Steven Rostedt (VMware) <rostedt@...dmis.org>
> 

I take that back. This isn't the patch I reviewed :-p (I'm not sure I
totally agree with the entire change, but I'm not going to argue it
either).

I was reviewing patch 3, but needed to apply this patch to look at all
the changes of patch 3, but I did the reply here, where it was meant
for patch 3.

-- Steve