linux-kernel - Re: [PATCH 6/8] Documentation: dt: Add new compatible to STM32 pinctrl driver bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <abee01c1-da4f-97b4-258a-3ab937f620eb@st.com>
Date:   Wed, 1 Feb 2017 16:58:23 +0100
From:   Alexandre Torgue <alexandre.torgue@...com>
To:     Rob Herring <robh@...nel.org>
CC:     Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Mark Rutland <mark.rutland@....com>,
        Arnd Bergmann <arnd@...db.de>,
        Russell King <linux@...linux.org.uk>,
        Olof Johansson <olof@...om.net>,
        Patrice Chotard <patrice.chotard@...com>,
        <lee.jones@...aro.org>, <linux-arm-kernel@...ts.infradead.org>,
        <devicetree@...r.kernel.org>, <linux-gpio@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 6/8] Documentation: dt: Add new compatible to STM32
 pinctrl driver bindings


On 02/01/2017 04:06 PM, Rob Herring wrote:
> On Fri, Jan 27, 2017 at 05:15:19PM +0100, Alexandre TORGUE wrote:
>> Add new compatible for stm32f469 MCU.
>>
>> Signed-off-by: Alexandre TORGUE <alexandre.torgue@...com>
>>
>> diff --git a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.txt
>> index 25d9809..4f0487d 100644
>> --- a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.txt
>> +++ b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.txt
>> @@ -9,7 +9,8 @@ Pin controller node:
>>  Required properies:
>>   - compatible: value should be one of the following:
>>     (a) "st,stm32f429-pinctrl"
>> -   (b) "st,stm32f746-pinctrl"
>> +   (b) "st,stm32f469-pinctrl"
>> +   (c) "st,stm32f746-pinctrl"
>
> Drop the a,b,c. Otherwise, you'll be changing a bunch of lines every
> time.

I completely agree.

Linus, Do i need to send a v2 for this patch ?

>
> With that,
>
> Acked-by: Rob Herring <robh@...nel.org>
>
>
>>   - #address-cells: The value of this property must be 1
>>   - #size-cells	: The value of this property must be 1
>>   - ranges	: defines mapping between pin controller node (parent) to
>> --
>> 1.9.1
>>